From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Preventing abort() and exit() calls in libpq
Date: Mon, 28 Jun 2021 10:20:52 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2106281013430.1401908@pseudo> (raw)
In-Reply-To: <YNl/rGAtp0Ovmtis@paquier.xyz>
References: <3128896.1624742969@sss.pgh.pa.us>
<YNl/rGAtp0Ovmtis@paquier.xyz>
>> +# Check for functions that libpq must not call.
>> +# (If nm doesn't exist or doesn't work on shlibs, this test will silently
>> +# do nothing, which is fine.)
>> +.PHONY: check-libpq-refs
>> +check-libpq-refs: $(shlib)
>> + @! nm -A -g -u $< 2>/dev/null | grep -e abort -e exit
>
> "abort" and "exit" could be generic terms present in some other
> libraries. Could be be better to match with "U abort" and "U exit"
> instead? MinGW has a nm command, and it has a compatible option set,
> so I think that it should work.
A possible trick is to add ccp flags such as: -Dexit=exit_BAD
-Dabort=abort_BAD.
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, michael@paquier.xyz, tgl@sss.pgh.pa.us, pchampion@vmware.com, daniel@yesql.se
Subject: Re: Preventing abort() and exit() calls in libpq
In-Reply-To: <alpine.DEB.2.22.394.2106281013430.1401908@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox