From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Zhijie Hou <houzhijie22@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add a hook for handling logical decoding messages on subscribers.
Date: Fri, 20 Nov 2026 04:32:25 +0000
Message-ID: <av/NWaZl/t6DAGvO@bdtpg> (raw)
In-Reply-To: <CAD21AoAtSSr_khQCvdvoozU1EZ7A1S5_X4-6NXZA4rsx0ZxzMQ@mail.gmail.com>
References: <CAA4eK1K3ypFDLk1R1DEx7YqCRbjNLTtJPP5+FfcX0F63rQ+Ekg@mail.gmail.com>
<avWPil2vQXgXQBn+@bdtpg>
<CAD21AoDQdj2xouprHesGvSFGVwZYJJp=qZfgUL6m_HLdEMvaoQ@mail.gmail.com>
<4d9e1d2f-27a2-40ec-92c8-4b5740736cf8@gmail.com>
<CAD21AoCbrcp=E5M4uMxfHLXsJsKfDscBoy-Bfhvqt6YuMhOEgw@mail.gmail.com>
<avwM5nLKh0lApeKU@bdtpg>
<CAD21AoDYLM7BQsDs7Mw91MeZusDZVekuuBK7eSgVJo3=a8DCuA@mail.gmail.com>
<av1JIyFMSMRXzzt0@bdtpg>
<CAA4eK1LFzsjPsmF6Bk2O1UKQBGumwb83RV8P_5GT2iDUvSfyuA@mail.gmail.com>
<CAD21AoAtSSr_khQCvdvoozU1EZ7A1S5_X4-6NXZA4rsx0ZxzMQ@mail.gmail.com>
Hi,
On Thu, Nov 19, 2026 at 03:42:06PM -0800, Masahiko Sawada wrote:
> On Thu, Nov 19, 2026 at 2:49 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Wed, Nov 18, 2026 at 12:13 PM Bertrand Drouvot
> > <bertranddrouvot.pg@gmail.com> wrote:
> > >
> > > On Tue, Nov 17, 2026 at 02:14:15PM -0800, Masahiko Sawada wrote:
> > > > On Tue, Nov 17, 2026 at 12:14 AM Bertrand Drouvot
> > > > <bertranddrouvot.pg@gmail.com> wrote:
> > >
> > > > Given that the 0001 patch is not backpatched, I think the subscriber
> > > > should request the messages option only from v20 or later publishers,
> > > > like it doesn't send the origin option to publishers older than v16.
> > > > The patch already checks the publisher version there, so we just need
> > > > to raise it from v14 to v20. What do you think?
> > >
> > > One difference with origin is that older publishers do not support that option
> > > at all, whereas v14 through v19 publishers support messages and the issue occurs
> > > only when streaming is enabled.
> > >
> > > I wonder if it would make sense to request messages from those publishers when
> > > streaming is disabled, and require v20 or later when streaming is enabled?
> > >
> >
> > We could use one of the ideas proposed or just leave as it is. It is
> > possible that there is no such use till now, so, adding more version
> > checking in the code for such things may not add much value.
>
> I'd like to keep it simple and require v20 or later regardless of the
> streaming option. Since streaming defaults to parallel, the
> subscribers would have to give up the performance benefit of
> streaming. So I don't think it's worth adding another check for them,
> as Amit said.
Yeah, that sounds reasonable to me.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: bertranddrouvot.pg@gmail.com, sawada.mshk@gmail.com, amit.kapila16@gmail.com, houzhijie22@gmail.com, bharath.rupireddyforpostgres@gmail.com, li.evan.chao@gmail.com, masao.fujii@gmail.com
Subject: Re: Add a hook for handling logical decoding messages on subscribers.
In-Reply-To: <av/NWaZl/t6DAGvO@bdtpg>
References: <CAA4eK1K3ypFDLk1R1DEx7YqCRbjNLTtJPP5+FfcX0F63rQ+Ekg@mail.gmail.com> <avWPil2vQXgXQBn+@bdtpg> <CAD21AoDQdj2xouprHesGvSFGVwZYJJp=qZfgUL6m_HLdEMvaoQ@mail.gmail.com> <4d9e1d2f-27a2-40ec-92c8-4b5740736cf8@gmail.com> <CAD21AoCbrcp=E5M4uMxfHLXsJsKfDscBoy-Bfhvqt6YuMhOEgw@mail.gmail.com> <avwM5nLKh0lApeKU@bdtpg> <CAD21AoDYLM7BQsDs7Mw91MeZusDZVekuuBK7eSgVJo3=a8DCuA@mail.gmail.com> <av1JIyFMSMRXzzt0@bdtpg> <CAA4eK1LFzsjPsmF6Bk2O1UKQBGumwb83RV8P_5GT2iDUvSfyuA@mail.gmail.com> <CAD21AoAtSSr_khQCvdvoozU1EZ7A1S5_X4-6NXZA4rsx0ZxzMQ@mail.gmail.com> <av/NWaZl/t6DAGvO@bdtpg>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox