From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ALTER TABLE on system catalogs
Date: Mon, 20 Aug 2018 14:38:25 +0200
Message-ID: <b49018c4-6592-eece-f5db-5978fda1f5df@2ndquadrant.com> (raw)
In-Reply-To: <20180820104825.a7yryvlycwimgttf@alap3.anarazel.de>
References: <e49f825b-fb25-0bc8-8afc-d5ad895c7975@2ndquadrant.com>
<20180627203733.bfpibxdleimvwdg2@alap3.anarazel.de>
<20180627230838.GI2667@paquier.xyz>
<9fb22a98-fd64-1426-a4f4-b927ce1a9a5e@2ndquadrant.com>
<920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com>
<20180820023749.GD7403@paquier.xyz>
<20180820104825.a7yryvlycwimgttf@alap3.anarazel.de>
On 20/08/2018 12:48, Andres Freund wrote:
> On 2018-08-20 11:37:49 +0900, Michael Paquier wrote:
>> On Fri, Jul 13, 2018 at 11:05:10AM +0200, Peter Eisentraut wrote:
>>> After reviewing that thread, I think my patch would still be relevant.
>>> Because the pending proposal is to not add TOAST tables to some catalogs
>>> such as pg_attribute, so my original use case of allowing ALTER TABLE /
>>> SET on system catalogs would still be broken for those tables.
>>
>> Something has happened in this area in the shape of 96cdeae, and the
>> following catalogs do not have toast tables: pg_class, pg_index,
>> pg_attribute and pg_largeobject*. While 0001 proposed upthread is not
>> really relevant anymore because there is already a test to list which
>> catalogs do not have a toast table. For 0002, indeed the patch is still
>> seems relevant. The comment block at the beginning of
>> create_toast_table should be updated.
>
> I still object to the approach in 0002.
Do you have an alternative in mind?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, andres@anarazel.de, michael@paquier.xyz
Subject: Re: ALTER TABLE on system catalogs
In-Reply-To: <b49018c4-6592-eece-f5db-5978fda1f5df@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox