From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Tightening up allowed custom GUC names
Date: Thu, 11 Feb 2021 15:04:17 -0500
Message-ID: <b7ef059e-4897-d2c2-62cb-7c5ebdc40f3e@dunslane.net> (raw)
In-Reply-To: <1477413.1613068373@sss.pgh.pa.us>
References: <951335.1612910077@sss.pgh.pa.us>
<20210209230155.GA551305@rfd.leadboat.com>
<1477413.1613068373@sss.pgh.pa.us>
On 2/11/21 1:32 PM, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
>> On Tue, Feb 09, 2021 at 05:34:37PM -0500, Tom Lane wrote:
>>> * A case could be made for tightening things up a lot more, and not
>>> allowing anything that doesn't look like an identifier. I'm not
>>> pushing for that, as it seems more likely to break existing
>>> applications than the narrow restriction proposed here. But I could
>>> live with it if people prefer that way.
>> I'd prefer that. Characters like backslash, space, and double quote have
>> significant potential to reveal bugs, while having negligible application
>> beyond revealing bugs.
> Any other opinions here? I'm hesitant to make such a change on the
> basis of just one vote.
>
>
That might be a bit restrictive. I could at least see allowing '-' as
reasonable, and maybe ':'. Not sure about other punctuation characters.
OTOH I'd be surprised if the identifier restriction would burden a large
number of people.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, tgl@sss.pgh.pa.us, noah@leadboat.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Tightening up allowed custom GUC names
In-Reply-To: <b7ef059e-4897-d2c2-62cb-7c5ebdc40f3e@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox