From: Jacob Champion <pchampion@vmware.com>
To: michael@paquier.xyz <michael@paquier.xyz>
To: m.kulagin@postgrespro.ru <m.kulagin@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Pull general SASL framework out of SCRAM
Date: Tue, 13 Jul 2021 22:41:01 +0000
Message-ID: <bf4c861d6331af782af1ec1639aaa00f18703504.camel@vmware.com> (raw)
In-Reply-To: <YO1rnHoIhxEUaBo6@paquier.xyz>
References: <9dc553fe86ba34bff1e0b636c493b527fc7bc030.camel@vmware.com>
<YNZ5Bqq4GvhNvbp0@paquier.xyz>
<0907fda41fb40b23e2cbdf7eb05a8d61dd5307b3.camel@vmware.com>
<YOLAIngluq5wOmgE@paquier.xyz>
<39a6bd825fd776f5f9c3a8eb7ca1c62f77cea433.camel@vmware.com>
<YOU2xFL/WoHl6ny0@paquier.xyz>
<5cf3c71d51a215d4103abcc686c69e79619e7b60.camel@vmware.com>
<YOao1wTwiWFsgL4p@paquier.xyz>
<5a75d91c1e06cce43ba038ccaa8bfded5cb35df2.camel@vmware.com>
<05ce01d777cb$40f31d60$c2d95820$@postgrespro.ru>
<YO1rnHoIhxEUaBo6@paquier.xyz>
On Tue, 2021-07-13 at 19:31 +0900, Michael Paquier wrote:
> On Tue, Jul 13, 2021 at 12:41:27PM +0300, Mikhail Kulagin wrote:
> > I got an error while building one of the extensions.
> > /home/mkulagin/pg-install/postgresql-master/include/internal/libpq-int.h:44:10: fatal error: fe-auth-sasl.h: No such file or directory
> > #include "fe-auth-sasl.h"
> > ^~~~~~~~~~~~~~~~
>
> Right. I overlooked the fact that libpq-int.h is installed.
Thanks for catching that Mikhail.
> > I think the new fe-auth-sasl.h file should be installed too.
> > Correction proposal in the attached file (but I'm not sure that fix
> > of Install.pm is correct).
>
> That looks correct to me. I'll check that tomorrow.
Looks right to me too. I'm currently rebuilding my Windows dev
environment so I haven't been able to double-check that piece of it.
Just to make sure -- do we want to export the fe-auth-sasl.h header as
opposed to forward-declaring the pg_fe_sasl_mech struct? Is the use
case for libpq-int.h just "here, have at the internals, and if you
break it then it's on you"?
--Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pchampion@vmware.com, michael@paquier.xyz, m.kulagin@postgrespro.ru
Subject: Re: [PATCH] Pull general SASL framework out of SCRAM
In-Reply-To: <bf4c861d6331af782af1ec1639aaa00f18703504.camel@vmware.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox