From: Jonathan S. Katz <jkatz@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Steven Pousty <steve.pousty@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Isaac Morland <isaac.morland@gmail.com>
Cc: Pierre Giraud <pierre.giraud@dalibo.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Poll: are people okay with function/operator table redesign?
Date: Wed, 29 Apr 2020 22:45:16 -0400
Message-ID: <c5f34a44-ccb9-c59e-ee5a-c8d97980df15@postgresql.org> (raw)
In-Reply-To: <18310.1588214299@sss.pgh.pa.us>
References: <20200423174343.GA16996@alvherre.pgsql>
<19233.1587665407@sss.pgh.pa.us>
<5561.1587922854@sss.pgh.pa.us>
<13e5e408-bc59-e8ca-44f3-28a981b4fc7d@postgresql.org>
<a47ea348-b9a0-02b7-5bcb-7a32143dd16f@postgresql.org>
<11211.1587951842@sss.pgh.pa.us>
<58de9544-be5b-f325-b5cc-cce4e2dda7d9@postgresql.org>
<5651.1587991781@sss.pgh.pa.us>
<b998a672-2525-1cba-ac64-b292f495919e@postgresql.org>
<30469.1588087170@sss.pgh.pa.us>
<8682.1588202983@sss.pgh.pa.us>
<4894cde4-148d-f0cc-d6d8-182a46f13e1b@postgresql.org>
<06f6b32d-a4cc-3723-5bc1-00fa674df961@postgresql.org>
<11106.1588205727@sss.pgh.pa.us>
<1c5ca197-f7f2-0300-46ce-4652c7f81d48@postgresql.org>
<ab7803b4-f985-cf3d-267f-38b7311ca917@postgresql.org>
<18310.1588214299@sss.pgh.pa.us>
On 4/29/20 10:38 PM, Tom Lane wrote:
> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
>> Please see latest attached. I've eliminated the !important, condensed
>> the CSS, and the desultory (yes, my word of the week) testing did not
>> find issues in devel or earlier versions.
>
>> Please let me know if this works for you. If it does, I'll push it up to
>> pgweb.
>
> NAK ... that does *not* work for me.
Learned a new acronym...
> It looks to me like you are expecting that "margin" with four parameters
> will override an outer-level setting of margin-bottom, but that is not
> how my browser is responding. ISTM you need to explicitly set the very
> same parameters in the more-specific rule as in the less-specific rule
> that you want to override.
>
> I get reasonable results with these settings, but not with
> anything more abbreviated:
> In particular, it might look like the multiple padding settings
> in the pre.programlisting rule are redundant ... but they are not, at
> least not with Safari.
Clearly I was caught doing a single browser test (Chrome).
Reverted back to the verbose way sans !important, attached, which
appears to be the consensus. If you can ACK this, I'll commit.
Thanks,
Jonathan
Attachments:website-style-v5.patch (text/plain, 1.3K) downloaddiff --git a/media/css/main.css b/media/css/main.cssindex 08ca255..2b4831d 100644--- a/media/css/main.css+++ b/media/css/main.css@@ -625,7 +625,7 @@ ul.actions {
}
#docContent p {
- margin-bottom: 1rem !important;+ margin-bottom: 1rem;
}
#docContent hr {
@@ -648,7 +648,7 @@ ul.actions {
}
#docContent pre {
- padding: 0.8rem !important;+ padding: 0.8rem;
}
pre,
@@ -658,7 +658,7 @@ code,
#docContent tt.REPLACEABLE {
font-size: 0.9rem !important;
color: inherit !important;
- background-color: #f8f9fa !important;+ background-color: #f8f9fa;
border-radius: .25rem;
margin: .6rem 0;
font-weight: 300;
@@ -799,6 +799,27 @@ code,
text-align: left;
}
+#docContent table.table th.func_table_entry p,+#docContent table.table td.func_table_entry p {+ margin-top: 0.1em;+ margin-bottom: 0.1em;+ padding-left: 4em;+ text-align: left;+}++#docContent table.table p.func_signature {+ text-indent: -3.5em;+}++#docContent table.table td.func_table_entry pre.programlisting {+ background-color: inherit;+ border: 0;+ margin-bottom: 0.1em;+ margin-top: 0.1em;+ padding: 0;+ padding-left: 4em;+}+
/**
* Titles, Navigation
*/
@@ -1059,7 +1080,7 @@ i.fas.fa-search {
pre {
padding: 0.8rem;
border: 1px solid #ced4da;
- margin: 1rem 0 !important;+ margin: 1rem 0;
}
pre.code {
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jkatz@postgresql.org, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, bruce@momjian.us, alvherre@2ndquadrant.com, robertmhaas@gmail.com, steve.pousty@gmail.com, pavel.stehule@gmail.com, isaac.morland@gmail.com, pierre.giraud@dalibo.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Poll: are people okay with function/operator table redesign?
In-Reply-To: <c5f34a44-ccb9-c59e-ee5a-c8d97980df15@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox