agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
Date: Mon, 21 Jan 2019 14:51:49 +0300
Message-ID: <cad38cdb-2bb1-da75-235f-2e6684826f10@postgrespro.ru> (raw)
In-Reply-To: <95aea959-97a1-2ded-c881-eede4e5a1f0c@2ndquadrant.com>
References: <27296.1522078068@sss.pgh.pa.us>
<20180327121954.GA12726@zakirov.localdomain>
<CA+TgmoaR_fVd_u60mA-PHO=J1u0PmdVGOt9WaxZ1UYuGq276oQ@mail.gmail.com>
<20180516113631.GA29544@zakirov.localdomain>
<20180614084015.GA12451@zakirov.localdomain>
<20181001092204.GA5071@zakirov.localdomain>
<68aaaff6-0efe-c14b-7aee-fb110bb97f69@2ndquadrant.com>
<337f7a55-58b8-4fcc-a933-5e7799fa6882@postgrespro.ru>
<e0a25563-cbb1-7089-8c25-44668cfb031b@postgrespro.ru>
<42b1ded6-fd44-5975-77e4-72ada1f134a2@2ndquadrant.com>
<20190120222121.ehistvcr4wsu2su5@alap3.anarazel.de>
<95aea959-97a1-2ded-c881-eede4e5a1f0c@2ndquadrant.com>
On 21.01.2019 02:43, Tomas Vondra wrote:
> On 1/20/19 11:21 PM, Andres Freund wrote:
>> On 2019-01-20 23:15:35 +0100, Tomas Vondra wrote:
>>> Thanks. I've reviewed v17 today and I haven't discovered any new issues
>>> so far. If everything goes fine and no one protests, I plan to get it
>>> committed over the next week or so.
>>
>> There doesn't seem to be any docs about what's needed to be able to take
>> advantage of shared dicts, and how to prevent them from permanently
>> taking up a significant share of memory.
>>
>
> Yeah, those are good points. I agree the comments might be clearer, but
> essentially ispell dictionaries are shared and everything else is not.
>
> As for the memory consumption / unloading dicts - I agree that's
> something we need to address. There used to be a way to specify memory
> limit and ability to unload dictionaries explicitly, but both features
> have been ditched. The assumption was that UNLOAD would be introduced
> later, but that does not seem to have happened.
I'll try to implement the syntax, you suggested earlier:
ALTER TEXT SEARCH DICTIONARY x UNLOAD/RELOAD
The main point here is that UNLOAD/RELOAD can't release the memory
immediately, because some other backend may pin a DSM.
The second point we should consider (I think) - how do we know which
dictionary should be unloaded. There was such function earlier, which
was removed. But what about adding an information in the "\dFd" psql's
command output? It could be a column which shows is a dictionary loaded.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
view thread (108+ messages) latest in thread
Message-ID: <cad38cdb-2bb1-da75-235f-2e6684826f10@postgrespro.ru>
Permalink: ../cad38cdb-2bb1-da75-235f-2e6684826f10@postgrespro.ru/
Also on: postgresql.org/message-id/cad38cdb-2bb1-da75-235f-2e6684826f10@postgrespro.ru
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.zakirov@postgrespro.ru, tomas.vondra@2ndquadrant.com, andres@anarazel.de, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pavel.stehule@gmail.com
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
In-Reply-To: <cad38cdb-2bb1-da75-235f-2e6684826f10@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox