public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Tom Lane <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Jakub Wartak <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: scalability bottlenecks with (many) partitions (and more)
Date: Tue, 4 Mar 2025 19:13:19 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<ffiwtzc6vedo6wb4gbwelon5nefqg675t5c7an2ta7pcz646cg@qwmkdb3l4ett>
	<[email protected]>
	<5xahykogf2sg3ofdqk2li7xx3t2vh23m42jnvfwxoi5fhh7iya@girlhoxdxjzc>
	<[email protected]>
	<vgtms7b5egxdypmknxpobocqton3puhprk3ahhk45rcx4uyl33@6uetxejsc75r>
	<[email protected]>
	<[email protected]>
	<nubyc3twqd7mtuyc2rbbt2yazjzbat6mlpfgxtb2ppv2egci3g@uvptf7xmh46m>
	<[email protected]>
	<qdvrgej743lcddjnb4lzyakt3f5bs2oz34r274wbmgc2g4474q@utqqrqiih65h>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>


On 2025-03-04 Tu 6:04 PM, Tom Lane wrote:
> Andrew Dunstan<[email protected]> writes:
>> Will check your patch out too.
> Comparing previous run against current, I now see that my patch
> caused it to skip these steps:
>
> module-ldap_password_func-check
> module-pg_bsd_indent-check
> contrib-sepgsql-check
>
> Skipping the ldap and sepgsql tests is desirable, but it shouldn't
> have skipped pg_bsd_indent.  I think the cause of that is that
> src/tools/pg_bsd_indent isn't built in any of the previous build
> steps.  Up to now it got built as a side-effect of invoking the
> tests, which isn't great because any build errors/warnings disappear
> into the install log which the script doesn't capture.  I agree
> with not capturing the install log, because that's generally
> uninteresting once we get past make-install; but we have to be sure
> that everything gets built before that.


Yeah ... I think an easy fix is to put this in make_testmodules():


+
+       # build pg_bsd_indent at the same time
+       # this doesn't really belong here, but it's convenient
+       if (-d "$pgsql/src/tools/pg_bsd_indent" && !$status)
+       {
+               my @indentout = run_log("cd 
$pgsql/src/tools/pg_bsd_indent && $make_cmd");
+               $status = $? >> 8;
+               push(@makeout,@indentout);
+       }


A lot of this special processing goes away when we're building with meson.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (34+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: scalability bottlenecks with (many) partitions (and more)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox