pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Vik Fearing <vik.fearing@2ndquadrant.com>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: pgsql-hackers@postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: Fix for FETCH FIRST syntax problems
Date: Sun, 20 May 2018 15:38:50 +0200
Message-ID: <d000efee-348c-0e31-4286-9732755b7d7e@2ndquadrant.com> (raw)
In-Reply-To: <87tvr32gvz.fsf@news-spur.riddles.org.uk>
References: <877enz476l.fsf@news-spur.riddles.org.uk>
	<22981.1526770675@sss.pgh.pa.us>
	<03da97fc-9d6b-cbe1-c28f-cee7c1ba5c38@2ndquadrant.com>
	<25267.1526773270@sss.pgh.pa.us>
	<20180519235706.GA1603@paquier.xyz>
	<87tvr32gvz.fsf@news-spur.riddles.org.uk>

On 20/05/18 05:25, Andrew Gierth wrote:
> +select_fetch_first_value:
> +			c_expr									{ $$ = $1; }
> +			| '+' I_or_F_const
> +				{ $$ = (Node *) makeSimpleA_Expr(AEXPR_OP, "+", NULL, $2, @1); }
> +			| '-' I_or_F_const
> +				{ $$ = doNegate($2, @1); }

I think there should be a comment for why you're accepting FCONST when
the value has to be integral.
-- 
Vik Fearing                                          +33 6 46 75 15 36
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support




view thread (19+ messages)  latest in thread

Message-ID: <d000efee-348c-0e31-4286-9732755b7d7e@2ndquadrant.com>
Permalink:  ../d000efee-348c-0e31-4286-9732755b7d7e@2ndquadrant.com/
Also on:    postgresql.org/message-id/d000efee-348c-0e31-4286-9732755b7d7e@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: vik.fearing@2ndquadrant.com, andrew@tao11.riddles.org.uk, tgl@sss.pgh.pa.us, michael@paquier.xyz
  Subject: Re: Fix for FETCH FIRST syntax problems
  In-Reply-To: <d000efee-348c-0e31-4286-9732755b7d7e@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox