From: Arne Roland <A.Roland@index.de>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rename of triggers for partitioned tables
Date: Tue, 20 Jul 2021 00:51:32 +0000
Message-ID: <d969d76ba62749699973a12499f944eb@index.de> (raw)
In-Reply-To: <004683a28e714bf3beb9a413a2ffbcb9@index.de>
References: <6e6491608f694ca488a5d7c404c4b98d@index.de>
<202107200003.nve6a53eixra@alvherre.pgsql>
<004683a28e714bf3beb9a413a2ffbcb9@index.de>
> We are referring the trigger via it's name after all. If a child is named differently we break with that assumption. I think informing the user about that, is very valuable.
To elaborate on that:
While we to similar things for things like set schema, here it has a functional relevance.
ALTER TRIGGER a5 ON table_name RENAME TO a9;
suggests that the trigger is now fired later from now on. Which obviously might not be the case, if one of the child triggers have had a different name.
I like your naming suggestions. I'm looking forward to test this patch when it applies at my end!
Regards
Arne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: A.Roland@index.de, alvherre@alvh.no-ip.org, vignesh21@gmail.com, zyu@yugabyte.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Rename of triggers for partitioned tables
In-Reply-To: <d969d76ba62749699973a12499f944eb@index.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox