From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: pg_upgrade test writes to source directory
Date: Sat, 28 May 2022 20:29:27 +0200
Message-ID: <defe6fe7-5824-5d87-b14f-0faee07e0b04@enterprisedb.com> (raw)
In-Reply-To: <YpHjviEL8jpu2Jn4@paquier.xyz>
References: <f80ace33-11fb-1cd3-20f8-98f51d151088@enterprisedb.com>
<Yo3Z5JzHXn7sIe9N@paquier.xyz>
<b68a2c98-8690-c057-c9e1-79bc6db608a0@enterprisedb.com>
<Yo/mWGJjCHOH3eB1@paquier.xyz>
<20220526205218.GC19626@telsasoft.com>
<50915523-5e3d-e1c7-9c38-d17263146e41@enterprisedb.com>
<YpHjviEL8jpu2Jn4@paquier.xyz>
On 28.05.22 10:56, Michael Paquier wrote:
> On Fri, May 27, 2022 at 02:45:57PM +0200, Peter Eisentraut wrote:
>> I think you can just chdir to ${PostgreSQL::Test::Utils::tmp_check}.
>
> Hmm. I think that I prefer your initial suggestion with TESTOUTDIR.
> This sticks better in the long term, while making things consistent
> with 010_tab_completion.pl, the only test that moves to TESTDIR while
> running. So my vote would be to backpatch first the addition of
> TESTOUTDIR, then fix the TAP test of pg_upgrade on HEAD to do the
> same.
I think it's a bit premature to talk about backpatching, since the patch
in question hasn't been committed anywhere yet, and AFAICT hasn't even
really been reviewed yet.
If you want to go this direction, I suggest you extract the patch and
present it here on its own merit. -- But then I might ask why such a
broad change post beta when apparently a one-line change would also work.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz, pryzby@telsasoft.com, andres@anarazel.de
Subject: Re: pg_upgrade test writes to source directory
In-Reply-To: <defe6fe7-5824-5d87-b14f-0faee07e0b04@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox