From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: HEAPDEBUGALL is broken
Date: Tue, 21 Apr 2020 20:11:26 +0200
Message-ID: <e1309adf-a0f3-c5dd-7654-7034418b043e@2ndquadrant.com> (raw)
In-Reply-To: <26609.1587303428@sss.pgh.pa.us>
References: <645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com>
<26609.1587303428@sss.pgh.pa.us>
On 2020-04-19 15:37, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> The HEAPDEBUGALL define has been broken since PG12 due to tableam
>> changes. Should we just remove this? It doesn't look very useful.
>> It's been around since Postgres95.
>> If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL
>> (which still compiles correctly). Would we want to keep that?
>
> +1 for removing both. There are a lot of such debug "features"
> in the code, and few of them are worth anything IME.
removed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us
Subject: Re: HEAPDEBUGALL is broken
In-Reply-To: <e1309adf-a0f3-c5dd-7654-7034418b043e@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox