From: Peter Eisentraut <peter@eisentraut.org>
To: Bruce Momjian <bruce@momjian.us>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Tatsuo Ishii <ishii@postgresql.org>
Cc: tgl@sss.pgh.pa.us
Cc: daniel@yesql.se
Cc: pgsql-hackers@postgresql.org
Subject: Re: Doc: typo in config.sgml
Date: Tue, 15 Oct 2024 22:34:16 +0200
Message-ID: <f1bc1bcd-a71c-411a-9bfd-8cd6ec2ae007@eisentraut.org> (raw)
In-Reply-To: <Zw6eQxtpXIccYpOQ@momjian.us>
References: <2565921.1728531809@sss.pgh.pa.us>
<20241010.160041.949661508167788393.ishii@postgresql.org>
<20241011114122.c90f8a871462da36f2e2afeb@sraoss.co.jp>
<20241011.121650.2077607600187658573.ishii@postgresql.org>
<20241011123653.09a67d3ad7b60a59e4558403@sraoss.co.jp>
<Zw1rf7vm3FqpItw4@momjian.us>
<Zw1_j_jofafQbNKl@momjian.us>
<20241015101036.d8c29e4aada1c3e92ddcef9d@sraoss.co.jp>
<Zw6eQxtpXIccYpOQ@momjian.us>
On 15.10.24 18:54, Bruce Momjian wrote:
>> I agree with encoding non-Latin1 characters and disallowing non-ASCII
>> characters totally.
>>
>> I found your patch includes fixes in *.svg files, so how about checking
>> also them by check-non-ascii? Also, I think it is better to use perl instead
>> of grep because non-GNU grep doesn't support hex escape sequences. I've attached
>> a updated patch for Makefile. The changes in release.sgml above is not applied
>> yet, though.
> Yes, good idea on using Perl and checking svg files --- I have used your
> Makefile rule.
>
> Attached is an updated patch. I realized that the new rules apply to
> all SGML files, not just the release notes, so I have created
> README.non-ASCII and moved the description there.
I don't understand the point of this. Maybe it's okay to try to detect
certain "hidden" whitespace characters, like in the case that started
this thread. But I don't see the value in prohibiting all non-ASCII
characters, as is being proposed here.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter@eisentraut.org, bruce@momjian.us, nagata@sraoss.co.jp, ishii@postgresql.org, tgl@sss.pgh.pa.us, daniel@yesql.se
Subject: Re: Doc: typo in config.sgml
In-Reply-To: <f1bc1bcd-a71c-411a-9bfd-8cd6ec2ae007@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox