From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgindent vs dtrace on macos
Date: Fri, 22 May 2020 11:29:25 +0200
Message-ID: <fcbe3e68-19f8-ae3b-cf5a-3e420123826b@2ndquadrant.com> (raw)
In-Reply-To: <21042.1589983015@sss.pgh.pa.us>
References: <79ed5348-be7a-b647-dd40-742207186a22@2ndquadrant.com>
<21042.1589983015@sss.pgh.pa.us>
On 2020-05-20 15:56, Tom Lane wrote:
> On a closely related point: I was confused for awhile on Monday
> afternoon, wondering why the built tarballs didn't match my local
> tree. I eventually realized that when I'd run pgindent on Saturday,
> it had reformatted some generated files such as
> src/bin/psql/sql_help.h, causing those not to match the freshly-made
> ones in the tarball. I wonder if we should make an effort to ensure
> that our generated .h and .c files always satisfy pgindent.
We should generally try to do that, if only so that they don't appear
weird and random when looking at them.
I think in the past it would have been very difficult for a generation
script to emulate pgindent's weird un-indentation logic on trailing
lines, but that shouldn't be a problem anymore.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us
Subject: Re: pgindent vs dtrace on macos
In-Reply-To: <fcbe3e68-19f8-ae3b-cf5a-3e420123826b@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox