From: Robbie Harwood <rharwood@redhat.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v6] GSSAPI encryption support
Date: Tue, 15 Mar 2016 16:35:26 -0400
Message-ID: <jlgr3fbiinl.fsf@thriss.redhat.com> (raw)
In-Reply-To: <20160315195436.GE3127@tamriel.snowman.net>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
<jlgegbkmvxl.fsf@thriss.redhat.com>
<56E81852.1060005@pgmasters.net>
<CAB7nPqTjnLWBOepE+Oy5WZBjcq7sRJ9_uKvvXuThst9dvBxkZQ@mail.gmail.com>
<jlgtwk7il5x.fsf@thriss.redhat.com>
<20160315195436.GE3127@tamriel.snowman.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Stephen Frost <sfrost@snowman.net> writes:
> Robbie,
>
> * Robbie Harwood (rharwood@redhat.com) wrote:
>> Michael Paquier <michael.paquier@gmail.com> writes:
>> > - maj_stat = gss_accept_sec_context(
>> > - &min_stat,
>> > + maj_stat = gss_accept_sec_context(&min_stat,
>> >
>> > This is just noise.
>>
>> You're not wrong, though I do think it makes the code more readable by
>> enforcing style and this is a "cleanup" commit. I'll take it out if it
>> bothers you.
>
> First, thanks much for working on this, I've been following along the
> discussions and hope to be able to help move it to commit, once it's
> ready.
>
> Secondly, generally, speaking, we prefer that 'cleanup' type changes
> (particularly whitespace-only ones) are in independent commits which are
> marked as just whitespace/indentation changes. We have a number of
> organizations which follow our code changes and it makes it more
> difficult on them to include whitespace/indentation changes with code
> changes.
Thanks for the clarification. I'll be sure to take it out!
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rharwood@redhat.com, sfrost@snowman.net, michael.paquier@gmail.com, david@pgmasters.net
Subject: Re: [PATCH v6] GSSAPI encryption support
In-Reply-To: <jlgr3fbiinl.fsf@thriss.redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox