pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Dimitri Fontaine <dimitri@2ndQuadrant.fr>
To: Thom Brown <thom@linux.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Command Triggers, patch v11
Date: Sat, 03 Mar 2012 15:34:59 +0100
Message-ID: <m2obsd3g8c.fsf@2ndQuadrant.fr> (raw)
In-Reply-To: <CAA-aLv7rKY2i-uezD_=3fxu1QqnV1nHBkj71avWQzOqzWxrTHw@mail.gmail.com>
References: <m24nufq466.fsf@2ndQuadrant.fr>
	<CAA-aLv5H5_ALMRZFatX-wDEz1meMvQVJOsBBFTYox65jzAoN5Q@mail.gmail.com>
	<CAA-aLv4w9B27QP17zU-osme58gks0yEH7j8p5p1tKCWp2oq_Hw@mail.gmail.com>
	<CAA-aLv6Was-jZmigbH3_eLH3eqsEUPpf-p7FT2s1FjBdXAbeNA@mail.gmail.com>
	<CAA-aLv7=+b+CiaDrWi7bKBtnW=jMarVC1HpB0a+erTKP3B=5Zw@mail.gmail.com>
	<CAA-aLv4jkA-s9y+bW_53zfz0Zt2azULQ2dppQYoRRpWmW2fvNw@mail.gmail.com>
	<m28vjo2hlm.fsf@2ndQuadrant.fr>
	<CAA-aLv5zuJC2RtOPu_=-XOhJFROWLA7P=dtVHgHSdRp5wEzkjQ@mail.gmail.com>
	<4965.1330441437@sss.pgh.pa.us>
	<4F4C99AD0200002500045C72@gw.wicourts.gov>
	<CA+TgmoZkgpzFkw2odrog1r6x2Wwqwk+mQizbFR6zoQbTk6BArQ@mail.gmail.com>
	<m2hay56bo9.fsf@2ndQuadrant.fr>
	<CAA-aLv7rKY2i-uezD_=3fxu1QqnV1nHBkj71avWQzOqzWxrTHw@mail.gmail.com>

Thom Brown <thom@linux.com> writes:
> problem.  It was the DROP COMMAND TRIGGER statement that garnered
> comment, as it makes more sense to drop the entire trigger than
> individual commands for that trigger.

What you're saying here is that a single command could have more than
one command attached to it, and what I understand Tom, Robert and Kevin
are saying is that any given command trigger should only be attached to
a single command.

If we wanted to be more consistent we would need to have a way to attach
the same trigger to both BEFORE and AFTER the command, as of now you
need two triggers here.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support



view thread (115+ messages)  latest in thread

Message-ID: <m2obsd3g8c.fsf@2ndQuadrant.fr>
Permalink:  ../m2obsd3g8c.fsf@2ndQuadrant.fr/
Also on:    postgresql.org/message-id/m2obsd3g8c.fsf@2ndQuadrant.fr

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: dimitri@2ndQuadrant.fr, thom@linux.com, robertmhaas@gmail.com, Kevin.Grittner@wicourts.gov, tgl@sss.pgh.pa.us
  Subject: Re: Command Triggers, patch v11
  In-Reply-To: <m2obsd3g8c.fsf@2ndQuadrant.fr>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox