pg.ddx.io  pgsql-interfaces@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <pgman@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Gerhard Häring <lists@ghaering.de>
Cc: pgsql-interfaces@postgresql.org
Subject: Re: I want to send comments to the backend!
Date: Fri, 21 Mar 2003 00:59:56 -0500 (EST)
Message-ID: <200303210559.h2L5xv110719@candle.pha.pa.us> (raw)
In-Reply-To: <10177.1048225294@sss.pgh.pa.us>


I now understand that IsUnderPostmaster isn't needed, as you suggested
below.


---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > OK, this patch fixes the comment passing bug.  I remove the strspn() and
> > added a boolean to test if any parsetree had been generated --- if not,
> > I call NullCommand().
> 
> Seems like the hard way.  I had in mind a quick
> 
> 	if (parsetree_list == NIL)
> 	{
> 		NullCommand(dest);
> 		return;
> 	}
> 
> before entering the main loop.  It'd take a small amount of reordering
> of the existing code to make this happen without adding any more code
> than that, but it looked doable.
> 
> 			regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073



view thread (25+ messages)  latest in thread

Message-ID: <200303210559.h2L5xv110719@candle.pha.pa.us>
Permalink:  ../200303210559.h2L5xv110719@candle.pha.pa.us/
Also on:    postgresql.org/message-id/200303210559.h2L5xv110719@candle.pha.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-interfaces@postgresql.org
  Cc: pgman@candle.pha.pa.us, tgl@sss.pgh.pa.us, lists@ghaering.de
  Subject: Re: I want to send comments to the backend!
  In-Reply-To: <200303210559.h2L5xv110719@candle.pha.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox