From: Hiroshi Inoue <Inoue@tpf.co.jp>
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: Keith Millard <Kmillard@pumatech.com>
Cc: PostgreSQL odbc list <pgsql-odbc@postgresql.org>
Subject: Re: Re: [INTERFACES] Postgres odbc driver bug
Date: Wed, 09 May 2001 11:05:47 +0900
Message-ID: <3AF8A5FB.819D8A92@tpf.co.jp> (raw)
References: <200105090153.f491rWd17938@candle.pha.pa.us>
Bruce Momjian wrote:
>
> > Bruce Momjian wrote:
> > >
> > > OK, I have created a context diff of your changes, which is
> > attached.
> > > Can someone comment on this? The patch appears to deal with
> > > STMT_PREMATURE differently than our current code.
> > >
> > > In fact, it seems to disable this code:
> > >
> > > /*
> > > * If the statement is premature, it means we already executed it from
> > > * an SQLPrepare/SQLDescribeCol type of scenario. So just return
> > > * success.
> > > */
> > > if (stmt->prepare && stmt->status == STMT_PREMATURE)
> > >
> >
> > Though this fixes the bug reported by Keith, STMT_PREMATURE
> > loses its meaning and SC_pre_execute() does a non-essential
> > work as a result. Possibly SQLPrepare() must be rewritten
> > though I'm not sure.
>
[snip]
>
> And you are saying that this patch fixes a different problem. The user
> reported his problems were fixed by that patch, so I am inclined to
> apply it.
>
I don't agree to apply the patch because the patch makes
the current code hardly understandable.
regards,
Hiroshi inoue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-interfaces@postgresql.org
Cc: Inoue@tpf.co.jp, pgman@candle.pha.pa.us, Kmillard@pumatech.com, pgsql-odbc@postgresql.org
Subject: Re: Re: [INTERFACES] Postgres odbc driver bug
In-Reply-To: <3AF8A5FB.819D8A92@tpf.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox