From: Simon Riggs <simon@2ndquadrant.com>
To: Martijn van Oosterhout <kleptog@svana.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ron Peacetree <rjpeace@earthlink.net>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] A Better External Sort?
Date: Tue, 04 Oct 2005 15:56:53 +0100
Message-ID: <1128437813.8603.305.camel@localhost.localdomain> (raw)
In-Reply-To: <20051004143041.GH17589@svana.org>
References: <18329659.1128188552696.JavaMail.root@elwamui-polski.atl.sa.earthlink.net>
<20051001215602.GG13830@svana.org>
<29837.1128223567@sss.pgh.pa.us>
<20051002123240.GA30492@svana.org>
<20051002193835.GJ30492@svana.org>
<1128376292.8603.142.camel@localhost.localdomain>
<20051004100441.GC17589@svana.org>
<1128425094.8603.296.camel@localhost.localdomain>
<20051004122443.GF17589@svana.org>
<7788.1128434784@sss.pgh.pa.us>
<20051004143041.GH17589@svana.org>
On Tue, 2005-10-04 at 16:30 +0200, Martijn van Oosterhout wrote:
> On Tue, Oct 04, 2005 at 10:06:24AM -0400, Tom Lane wrote:
> > Martijn van Oosterhout <kleptog@svana.org> writes:
> > > I'm using: gcc (GCC) 3.3.5 (Debian 1:3.3.5-13)
> >
> > I don't know what the units of this number are, but it's apparently far
> > too gcc-version-dependent to consider putting into our build scripts.
> > Using gcc version 4.0.1 20050727 (current Fedora Core 4 compiler) on
> > i386, and compiling tuplesort.c as you did, I find:
> > -O2: warning goes away between 800 and 900
> > -O3: warning is always there (tried values up to 10000000)
> > (the latter behavior may indicate a bug, not sure).
>
> Facsinating. The fact that the warning goes away if you don't specify
> -finline-limit seems to indicate they've gotten smarter. Or a bug.
> We'd have to check the asm code to see if it's actually inlined or
> not.
I've been using gcc 3.4 and saw no warning when using either "-Winline"
or "-O3 -Winline".
Martijn, at the moment it sounds like this is a feature that we no
longer need to support - even if we should have done for previous
releases.
Best Regards, Simon Riggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: simon@2ndquadrant.com, kleptog@svana.org, tgl@sss.pgh.pa.us, rjpeace@earthlink.net, pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] A Better External Sort?
In-Reply-To: <1128437813.8603.305.camel@localhost.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox