From: Merlin Moncure <mmoncure@gmail.com>
To: Thom Brown <thombrown@gmail.com>
Cc: pgsql-php@postgresql.org, PGSQL Mailing List <pgsql-general@postgresql.org>
Subject: Re: PostgreSQL driver for Joomla review
Date: Tue, 20 Oct 2009 09:46:52 -0400
Message-ID: <b42b73150910200646v645ccbd0w216fd25d471af18a@mail.gmail.com> (raw)
In-Reply-To: <bddc86150910200502j201b60d5l569b5da410aed402@mail.gmail.com>
References: <bddc86150910200502j201b60d5l569b5da410aed402@mail.gmail.com>
On Tue, Oct 20, 2009 at 8:02 AM, Thom Brown <thombrown@gmail.com> wrote:
> If anyone has a moment, could they review the PostgreSQL driver I
> wrote for Joomla's next major release? The developers at Joomla have
> listened to the persistent noise created about only having MySQL as an
> option and are now accepting submissions for alternative database
> systems. (see http://groups.google.com/group/joomla-dev-cms/browse_thread/thread/1382dc6f4af56278#msg_9b95648941ef...
> for this development)
>
> My submission can be found at:
> http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=18384
>
> Things to watch out for a version-dependent features and clumsy implementations.
*) why bother with the version check in queryBatch? why not just do
begin->commit always?
*) no ability to delete?
*) looks like typo on line 713
keep up the good work...
merlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-php@postgresql.org
Cc: mmoncure@gmail.com, thombrown@gmail.com, pgsql-general@postgresql.org
Subject: Re: PostgreSQL driver for Joomla review
In-Reply-To: <b42b73150910200646v645ccbd0w216fd25d471af18a@mail.gmail.com>
References: <bddc86150910200502j201b60d5l569b5da410aed402@mail.gmail.com> <b42b73150910200646v645ccbd0w216fd25d471af18a@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox