From: Thom Brown <thombrown@gmail.com>
To: Alban Hertroys <dalroi@solfertje.student.utwente.nl>
Cc: pgsql-php@postgresql.org, PGSQL Mailing List <pgsql-general@postgresql.org>
Subject: Re: PostgreSQL driver for Joomla review
Date: Tue, 20 Oct 2009 20:00:19 +0100
Message-ID: <bddc86150910201200s6535464o42bc480ed2eb56b8@mail.gmail.com> (raw)
In-Reply-To: <0C148B43-DF74-4DA6-866E-9903A540797D@solfertje.student.utwente.nl>
References: <bddc86150910200502j201b60d5l569b5da410aed402@mail.gmail.com>
<0C148B43-DF74-4DA6-866E-9903A540797D@solfertje.student.utwente.nl>
2009/10/20 Alban Hertroys <dalroi@solfertje.student.utwente.nl>:
> You miss a keyword in your query in renameTable; it should be " RENAME TO ",
> not " TO ".
Thanks for spotting that. I've made my amendments for next submit.
> Wouldn't it be convenient to have an EXPLAIN ANALYSE version of explain()?
> Maybe with a boolean parameter?
The problem is, I don't see where they're using this function, so if
they're using it to EXPLAIN an INSERT, UPDATE or DELETE statement,
ANALYZE would execute it... unless I roll it back straight after.
> In insertObject() you have a query "SELECT $keyName AS 'id' FROM $table'" -
> That line contains two syntax errors: 'id' (You probably meant "id") and
> $table' (spurious trailing quote).
Again, you're right and well spotted. :) Fixed both of those.
Cheers for helping out Alban! :D
Thom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-php@postgresql.org
Cc: thombrown@gmail.com, dalroi@solfertje.student.utwente.nl, pgsql-general@postgresql.org
Subject: Re: PostgreSQL driver for Joomla review
In-Reply-To: <bddc86150910201200s6535464o42bc480ed2eb56b8@mail.gmail.com>
References: <bddc86150910200502j201b60d5l569b5da410aed402@mail.gmail.com> <0C148B43-DF74-4DA6-866E-9903A540797D@solfertje.student.utwente.nl> <bddc86150910201200s6535464o42bc480ed2eb56b8@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox