public inbox for [email protected]
help / color / mirror / Atom feedinit script for pgpool
22+ messages / 4 participants
[nested] [flat]
* init script for pgpool
@ 2015-09-14 13:00 Andrew N Golovkov <[email protected]>
2015-09-15 04:20 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
0 siblings, 2 replies; 22+ messages in thread
From: Andrew N Golovkov @ 2015-09-14 13:00 UTC (permalink / raw)
To: pgsql-pkg-yum
Can you fix init script for pgpool in repository?
In mainstream start/stop issues fixed 28.05.2014:
> $SU -l $PGPOOLUSER -c "$PGPOOLDAEMON -f $PGPOOLCONF -m fast stop" >> "$PGPOOLLOG" 2>&1 < /dev/null
But yum repo have old init-script:
> killproc /usr/bin/pgpool
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
@ 2015-09-15 04:20 ` Jeff Frost <[email protected]>
2015-09-15 05:27 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
1 sibling, 1 reply; 22+ messages in thread
From: Jeff Frost @ 2015-09-15 04:20 UTC (permalink / raw)
To: Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
I'll take a look at this tomorrow.
Sent from my iPhone
> On Sep 14, 2015, at 06:00, Andrew N Golovkov <[email protected]> wrote:
>
> Can you fix init script for pgpool in repository?
> In mainstream start/stop issues fixed 28.05.2014:
>
>> $SU -l $PGPOOLUSER -c "$PGPOOLDAEMON -f $PGPOOLCONF -m fast stop" >> "$PGPOOLLOG" 2>&1 < /dev/null
>
> But yum repo have old init-script:
>
>> killproc /usr/bin/pgpool
>
>
> --
> Sent via pgsql-pkg-yum mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-pkg-yum
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-15 04:20 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-15 05:27 ` Devrim GÜNDÜZ <[email protected]>
2015-09-16 00:28 ` Re: init script for pgpool Jeff Frost <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Devrim GÜNDÜZ @ 2015-09-15 05:27 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
Hi Jeff,
On Mon, 2015-09-14 at 21:20 -0700, Jeff Frost wrote:
> I'll take a look at this tomorrow.
Thanks! For the records, upstream init script is here:
http://git.postgresql.org/gitweb/?p=pgpool2.git;a=blob_plain;f=src/redh
at/pgpool.init;hb=HEAD
Regards,
--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-15 04:20 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-15 05:27 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
@ 2015-09-16 00:28 ` Jeff Frost <[email protected]>
2015-09-16 08:25 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Jeff Frost @ 2015-09-16 00:28 UTC (permalink / raw)
To: Devrim GÜNDÜZ <[email protected]>; +Cc: Andrew N Golovkov <[email protected]>; pgsql-pkg-yum
So generally speaking we’ve diverged because we tack on the -<pgversion> number on the binary locations, so we can’t just grab the pgpool-2 community scripts and use them. Do you think we need to do that? Is that so we can install multiple versions side by side?
> On Sep 14, 2015, at 10:27 PM, Devrim GÜNDÜZ <[email protected]> wrote:
>
>
> Hi Jeff,
>
> On Mon, 2015-09-14 at 21:20 -0700, Jeff Frost wrote:
>> I'll take a look at this tomorrow.
>
> Thanks! For the records, upstream init script is here:
>
> http://git.postgresql.org/gitweb/?p=pgpool2.git;a=blob_plain;f=src/redh
> at/pgpool.init;hb=HEAD
>
> Regards,
> --
> Devrim GÜNDÜZ
> Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
> PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR
>
>
>
>
>
> --
> Sent via pgsql-pkg-yum mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-pkg-yum
---
Jeff Frost <[email protected]>
CTO, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-15 04:20 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-15 05:27 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
2015-09-16 00:28 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-16 08:25 ` Devrim GÜNDÜZ <[email protected]>
2015-09-16 15:18 ` Re: init script for pgpool Jeff Frost <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Devrim GÜNDÜZ @ 2015-09-16 08:25 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; +Cc: Andrew N Golovkov <[email protected]>; pgsql-pkg-yum
Hi Jeff,
On Tue, 2015-09-15 at 17:28 -0700, Jeff Frost wrote:
> So generally speaking we’ve diverged because we tack on the
> -<pgversion> number on the binary locations, so we can’t just grab
> the pgpool-2 community scripts and use them. Do you think we need to
> do that? Is that so we can install multiple versions side by side?
I sent the link just for a reference to replace killproc --other than
that, you are correct. We will keep our script as is, except the bugs.
Cheers,
--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-15 04:20 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-15 05:27 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
2015-09-16 00:28 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-16 08:25 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
@ 2015-09-16 15:18 ` Jeff Frost <[email protected]>
2015-09-16 17:17 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Jeff Frost @ 2015-09-16 15:18 UTC (permalink / raw)
To: Devrim GÜNDÜZ <[email protected]>; +Cc: Andrew N Golovkov <[email protected]>; pgsql-pkg-yum
> On Sep 16, 2015, at 01:25, Devrim GÜNDÜZ <[email protected]> wrote:
>
>
> Hi Jeff,
>
>> On Tue, 2015-09-15 at 17:28 -0700, Jeff Frost wrote:
>> So generally speaking we’ve diverged because we tack on the
>> -<pgversion> number on the binary locations, so we can’t just grab
>> the pgpool-2 community scripts and use them. Do you think we need to
>> do that? Is that so we can install multiple versions side by side?
>
> I sent the link just for a reference to replace killproc --other than
> that, you are correct. We will keep our script as is, except the bugs.
>
Ok, sounds good. I'll fix it up. I also want to fix the whitespace because it's mixed with different indentation levels. Do you have a preference for 2 or 4 space indents?
> Cheers,
> --
> Devrim GÜNDÜZ
> Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
> PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR
>
>
>
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-15 04:20 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-15 05:27 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
2015-09-16 00:28 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-16 08:25 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
2015-09-16 15:18 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-16 17:17 ` Devrim GÜNDÜZ <[email protected]>
0 siblings, 0 replies; 22+ messages in thread
From: Devrim GÜNDÜZ @ 2015-09-16 17:17 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; +Cc: Andrew N Golovkov <[email protected]>; pgsql-pkg-yum
Hi,
On Wed, 2015-09-16 at 08:18 -0700, Jeff Frost wrote:
> Ok, sounds good. I'll fix it up. I also want to fix the whitespace
> because it's mixed with different indentation levels. Do you have a
> preference for 2 or 4 space indents?
Nope, we don't have a policy.
Regards,
--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
@ 2015-09-17 18:38 ` Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
1 sibling, 1 reply; 22+ messages in thread
From: Jeff Frost @ 2015-09-17 18:38 UTC (permalink / raw)
To: Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
Andrew, I’ve pushed updates to jf/pgpool_fixes branch in the pgrpms project.
Would you like to test the init script for us before we merge it to master?
> On Sep 14, 2015, at 6:00 AM, Andrew N Golovkov <[email protected]> wrote:
>
> Can you fix init script for pgpool in repository?
> In mainstream start/stop issues fixed 28.05.2014:
>
>> $SU -l $PGPOOLUSER -c "$PGPOOLDAEMON -f $PGPOOLCONF -m fast stop" >> "$PGPOOLLOG" 2>&1 < /dev/null
>
> But yum repo have old init-script:
>
>> killproc /usr/bin/pgpool
>
>
> --
> Sent via pgsql-pkg-yum mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-pkg-yum
---
Jeff Frost <[email protected]>
CTO, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-18 12:40 ` Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Andrew N Golovkov @ 2015-09-18 12:40 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; +Cc: pgsql-pkg-yum
You forget $pidfile and $PGPOOLUSER and some more comments.
Check script in attach. I'm tested in my centos-6 and pgpool-II-92.
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
Attachments:
[text/x-shellscript] pgpool.init (4.0K, 2-pgpool.init)
download | inline:
#!/bin/sh
# pgpool This is the init script for starting up pgpool-II
#
# chkconfig: - 74 33
# description: Starts and stops the pgpool daemon
# processname: pgpool
# pidfile: /var/run/pgpool.pid
#
# v1.0.0 Devrim GUNDUZ <[email protected]>
# - Initial version of Red Hat / Fedora init script
#
# v2.2 Devrim GUNDUZ <[email protected]>
# - New and improved version which has some fixes.
#
# v2.2.5 Devrim GUNDUZ <[email protected]>
# - Fix logging.
#
# v2.3 Devrim GUNDUZ <[email protected]>
# - Adjust order of startup and kill, per RH bugzilla #545739.
#
# v3.3.3 Ryan Deshone <[email protected]> and Yugo Nagata <[email protected]>
# - Update stop and reload to use pgpool commands properly
# - Removed "switch" as pgpool no longer suppports that command
# - Add try-restart option
# - Fix exit code according with LSB
# Source function library.
INITD=/etc/rc.d/init.d
. $INITD/functions
# Get function listing for cross-distribution logic.
TYPESET=`typeset -f|grep "declare"`
# Get config.
. /etc/sysconfig/network
# Check that networking is up.
# We need it for pgpool
[ "${NETWORKING}" = "no" ] && exit 0
# Find the name of the script
NAME=`basename $0`
if [ ${NAME:0:1} = "S" -o ${NAME:0:1} = "K" ]
then
NAME=${NAME:3}
fi
# For SELinux we need to use 'runuser' not 'su'
if [ -x /sbin/runuser ]
then
SU=runuser
else
SU=su
fi
# Set defaults for configuration variables
PGPOOLUSER=postgres
PGPOOLENGINE=/usr/pgpool-9.2/bin
PGPOOLDAEMON=$PGPOOLENGINE/pgpool
PGPOOLCONF=/etc/pgpool-II-92/pgpool.conf
PGPOOLPIDDIR=/var/run/pgpool-II-92
PGPOOLLOG=/var/log/pgpool-II-92.log
lockfile="/var/lock/subsys/${NAME}"
pidfile="$PGPOOLPIDDIR/pgpool.pid"
# Import configuration from /etc/sysconfig, if it exists
if [ -r /etc/sysconfig/pgpool-II-92 ]; then
. /etc/sysconfig/pgpool-II-92
fi
test -x $PGPOOLDAEMON || exit 5
# Check whether the config file exists or not
if [ ! -r $PGPOOLCONF ]
then
echo "$PGPOOLCONF not found"
echo_failure
echo
exit 1
fi
# Create the log file if it does not exist
if [ ! -x $PGPOOLLOG ]
then
touch $PGPOOLLOG
chown ${PGPOOLUSER}: $PGPOOLLOG
fi
if [ ! -d $PGPOOLPIDDIR ]
then
mkdir $PGPOOLPIDDIR
chown ${PGPOOLUSER}: $PGPOOLPIDDIR
fi
script_result=0
start(){
PGPOOL_START=$"Starting ${NAME} service: "
echo -n "$PGPOOL_START"
pid="`pidofproc -p "$pidfile" -s "$PGPOOLDAEMON"`"
if [ -n "$pid" ] ; then
echo -n "pgpool is already running with pid $pid "
echo_failure
script_result=1
else
$SU -l $PGPOOLUSER -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
sleep 2
pid="`pidofproc -p "$pidfile" -s "$PGPOOLDAEMON"`"
if [ -n "$pid" ] ; then
echo_success
touch "$lockfile"
else
echo_failure
script_result=1
fi
fi
echo
}
stop(){
PGPOOL_STOP=$"Stopping ${NAME} service: "
echo -n "$PGPOOL_STOP"
if [ -e "$lockfile" ] ; then
$SU -l $PGPOOLUSER -c "$PGPOOLDAEMON -f $PGPOOLCONF -m fast stop" >> "$PGPOOLLOG" 2>&1 < /dev/null
RETVAL=$?
if [ $RETVAL -eq 0 ] ; then
echo_success
rm -f "$lockfile"
else
echo_failure
script_result=1
fi
else
echo_success
fi
echo
}
restart(){
stop
start
}
reload(){
PGPOOL_RELOAD=$"Reloading ${NAME} configuration: "
echo -n "$PGPOOL_RELOAD"
pid="`pidofproc -p $pidfile $PGPOOLDAEMON`"
if [ -n "$pid" ] ; then
$SU -l $PGPOOLUSER -c "$PGPOOLDAEMON -f $PGPOOLCONF reload" >> "$PGPOOLLOG" 2>&1 < /dev/null
RETVAL=$?
if [ $RETVAL -eq 0 ]; then
echo_success
else
echo_failure
script_result=1
fi
else
echo -n "pgpool is not running "
echo_failure
script_result=1
fi
echo
}
condrestart(){
[ -e "$lockfile" ] && restart
}
condstop(){
[ -e "$lockfile" ] && stop
}
# See how we were called.
case "$1" in
start)
start
;;
stop)
stop
;;
status)
status -p $pidfile pgpool
script_result=$?
;;
restart)
restart
;;
reload|force-reload)
reload
;;
condrestart)
condrestart
;;
condstop)
condstop
;;
*)
echo $"Usage: $0 {start|stop|status|restart|condrestart|condstop|reload|force-reload}"
exit 1
esac
exit $script_result
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
@ 2015-09-18 17:17 ` Jeff Frost <[email protected]>
2015-09-18 17:27 ` Re: init script for pgpool Devrim Gündüz <[email protected]>
2015-09-18 19:23 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
0 siblings, 2 replies; 22+ messages in thread
From: Jeff Frost @ 2015-09-18 17:17 UTC (permalink / raw)
To: Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
Nice catch! I found a couple other things as well, so here’s an updated version:
http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>
> You forget $pidfile and $PGPOOLUSER and some more comments.
>
> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
> --
> Sent via pgsql-pkg-yum mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-pkg-yum
---
Jeff Frost <[email protected]>
CTO, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-18 17:27 ` Devrim Gündüz <[email protected]>
2015-09-18 17:33 ` Re: init script for pgpool Jeff Frost <[email protected]>
1 sibling, 1 reply; 22+ messages in thread
From: Devrim Gündüz @ 2015-09-18 17:27 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
Hi Jeff,
Can you please update the changelog inside the script, too?
Cheers, Devrim
On September 18, 2015 8:17:50 PM GMT+03:00, Jeff Frost <[email protected]> wrote:
>Nice catch! I found a couple other things as well, so here’s an
>updated version:
>
>http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>
>It seems to work in my vagrant, so let me know if it works for you and
>I’ll get it merged, then the next time we build, we’ll have it in the
>repo.
>
>
>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]>
>wrote:
>>
>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>
>> Check script in attach. I'm tested in my centos-6 and
>pgpool-II-92.<pgpool.init>
>> --
>> Sent via pgsql-pkg-yum mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>
>---
>Jeff Frost <[email protected]>
>CTO, PostgreSQL Experts, Inc.
>Phone: 1-888-PG-EXPRT x506
>FAX: 415-762-5122
>http://www.pgexperts.com/
>
>
>
>
>
>--
>Sent via pgsql-pkg-yum mailing list ([email protected])
>To make changes to your subscription:
>http://www.postgresql.org/mailpref/pgsql-pkg-yum
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 17:27 ` Re: init script for pgpool Devrim Gündüz <[email protected]>
@ 2015-09-18 17:33 ` Jeff Frost <[email protected]>
2015-09-18 18:04 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Jeff Frost @ 2015-09-18 17:33 UTC (permalink / raw)
To: Devrim GÜNDÜZ <[email protected]>; +Cc: Andrew N Golovkov <[email protected]>; pgsql-pkg-yum
Sure! Do you think just v 2.4?
> On Sep 18, 2015, at 10:27 AM, Devrim Gündüz <[email protected]> wrote:
>
> Hi Jeff,
>
> Can you please update the changelog inside the script, too?
>
> Cheers, Devrim
>
> On September 18, 2015 8:17:50 PM GMT+03:00, Jeff Frost <[email protected]> wrote:
> Nice catch! I found a couple other things as well, so here’s an updated version:
>
> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i... <http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...;
>
> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>
>
> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>
> You forget $pidfile and $PGPOOLUSER and some more comments.
>
> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
> --
> Sent via pgsql-pkg-yum mailing list
> ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-pkg-yum <http://www.postgresql.org/mailpref/pgsql-pkg-yum;
>
> ---
> Jeff Frost <[email protected]>
> CTO, PostgreSQL Experts, Inc.
> Phone: 1-888-PG-EXPRT x506
> FAX: 415-762-5122
> http://www.pgexperts.com <http://www.pgexperts.com/>/
>
>
>
>
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
---
Jeff Frost <[email protected]>
CTO, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 17:27 ` Re: init script for pgpool Devrim Gündüz <[email protected]>
2015-09-18 17:33 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-18 18:04 ` Devrim GÜNDÜZ <[email protected]>
0 siblings, 0 replies; 22+ messages in thread
From: Devrim GÜNDÜZ @ 2015-09-18 18:04 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; +Cc: Andrew N Golovkov <[email protected]>; pgsql-pkg-yum
Hi,
On Fri, 2015-09-18 at 10:33 -0700, Jeff Frost wrote:
> Sure! Do you think just v 2.4?
Let's make it 3.4, so that it matches pgpool version as well.
Cheers,
--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-18 19:23 ` Andrew N Golovkov <[email protected]>
2015-09-18 20:44 ` Re: init script for pgpool Jeff Frost <[email protected]>
1 sibling, 1 reply; 22+ messages in thread
From: Andrew N Golovkov @ 2015-09-18 19:23 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; +Cc: pgsql-pkg-yum
You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
> $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
Please, look at my script i'v posted today.
18.09.2015, 20:17, "Jeff Frost" <[email protected]>:
> Nice catch! I found a couple other things as well, so here’s an updated version:
>
> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>
> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>
>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>>
>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>
>> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>> --
>> Sent via pgsql-pkg-yum mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>
> ---
> Jeff Frost <[email protected]>
> CTO, PostgreSQL Experts, Inc.
> Phone: 1-888-PG-EXPRT x506
> FAX: 415-762-5122
> http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 19:23 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
@ 2015-09-18 20:44 ` Jeff Frost <[email protected]>
2015-09-18 21:46 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Jeff Frost @ 2015-09-18 20:44 UTC (permalink / raw)
To: Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
> On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <[email protected]> wrote:
>
> You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
> Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
>> $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
>
> Please, look at my script i'v posted today.
>
> 18.09.2015, 20:17, "Jeff Frost" <[email protected]>:
>> Nice catch! I found a couple other things as well, so here’s an updated version:
>>
>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>
>> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>>
>>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>>>
>>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>>
>>> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>>> --
>>> Sent via pgsql-pkg-yum mailing list ([email protected])
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>
>> ---
>> Jeff Frost <[email protected]>
>> CTO, PostgreSQL Experts, Inc.
>> Phone: 1-888-PG-EXPRT x506
>> FAX: 415-762-5122
>> http://www.pgexperts.com/
---
Jeff Frost <[email protected]>
CTO, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 19:23 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 20:44 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-18 21:46 ` Andrew N Golovkov <[email protected]>
2015-09-18 21:49 ` Re: init script for pgpool Jeff Frost <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Andrew N Golovkov @ 2015-09-18 21:46 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; +Cc: pgsql-pkg-yum
And again.
https://bpaste.net/show/20ee48a0fc81
Diff with your script and my (with little cosmetic changes from previous version).
18.09.2015, 23:45, "Jeff Frost" <[email protected]>:
> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>
>> On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <[email protected]> wrote:
>>
>> You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
>> Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
>>> $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
>>
>> Please, look at my script i'v posted today.
>>
>> 18.09.2015, 20:17, "Jeff Frost" <[email protected]>:
>>> Nice catch! I found a couple other things as well, so here’s an updated version:
>>>
>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>
>>> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>>>
>>>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>>>>
>>>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>>>
>>>> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>>>> --
>>>> Sent via pgsql-pkg-yum mailing list ([email protected])
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>>
>>> ---
>>> Jeff Frost <[email protected]>
>>> CTO, PostgreSQL Experts, Inc.
>>> Phone: 1-888-PG-EXPRT x506
>>> FAX: 415-762-5122
>>> http://www.pgexperts.com/
>
> ---
> Jeff Frost <[email protected]>
> CTO, PostgreSQL Experts, Inc.
> Phone: 1-888-PG-EXPRT x506
> FAX: 415-762-5122
> http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 19:23 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 20:44 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 21:46 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
@ 2015-09-18 21:49 ` Jeff Frost <[email protected]>
2015-09-18 22:26 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Jeff Frost @ 2015-09-18 21:49 UTC (permalink / raw)
To: Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
Could you use diff -b so it doesn’t show lines with just whitespace different?
> On Sep 18, 2015, at 2:46 PM, Andrew N Golovkov <[email protected]> wrote:
>
> And again.
>
> https://bpaste.net/show/20ee48a0fc81
>
> Diff with your script and my (with little cosmetic changes from previous version).
>
>
> 18.09.2015, 23:45, "Jeff Frost" <[email protected]>:
>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>
>>> On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <[email protected]> wrote:
>>>
>>> You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
>>> Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
>>>> $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
>>>
>>> Please, look at my script i'v posted today.
>>>
>>> 18.09.2015, 20:17, "Jeff Frost" <[email protected]>:
>>>> Nice catch! I found a couple other things as well, so here’s an updated version:
>>>>
>>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>>
>>>> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>>>>
>>>>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>>>>>
>>>>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>>>>
>>>>> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>>>>> --
>>>>> Sent via pgsql-pkg-yum mailing list ([email protected])
>>>>> To make changes to your subscription:
>>>>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>>>
>>>> ---
>>>> Jeff Frost <[email protected]>
>>>> CTO, PostgreSQL Experts, Inc.
>>>> Phone: 1-888-PG-EXPRT x506
>>>> FAX: 415-762-5122
>>>> http://www.pgexperts.com/
>>
>> ---
>> Jeff Frost <[email protected]>
>> CTO, PostgreSQL Experts, Inc.
>> Phone: 1-888-PG-EXPRT x506
>> FAX: 415-762-5122
>> http://www.pgexperts.com/
---
Jeff Frost <[email protected]>
CTO, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 19:23 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 20:44 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 21:46 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 21:49 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-18 22:26 ` Andrew N Golovkov <[email protected]>
2015-09-18 23:00 ` Re: init script for pgpool Jeff Frost <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Andrew N Golovkov @ 2015-09-18 22:26 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; +Cc: pgsql-pkg-yum
git diff -b: https://bpaste.net/show/89b37acb8f0a
Removed `switch' action, because not supported at least from 3.3.3, where init-script changed in upstream;
Every call stop/start/reload with correct calls and use variable `$PGPOOLUSER'
Removed unhandled arguments from `failure' and `success' function calls;
Cleanup useless commands and exit's.
Every line aligned with tabs;
Version in comment is 3.4 as proposed Devrim.
19.09.2015, 00:50, "Jeff Frost" <[email protected]>:
> Could you use diff -b so it doesn’t show lines with just whitespace different?
>
>> On Sep 18, 2015, at 2:46 PM, Andrew N Golovkov <[email protected]> wrote:
>>
>> And again.
>>
>> https://bpaste.net/show/20ee48a0fc81
>>
>> Diff with your script and my (with little cosmetic changes from previous version).
>>
>> 18.09.2015, 23:45, "Jeff Frost" <[email protected]>:
>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>
>>>> On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <[email protected]> wrote:
>>>>
>>>> You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
>>>> Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
>>>>> $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
>>>>
>>>> Please, look at my script i'v posted today.
>>>>
>>>> 18.09.2015, 20:17, "Jeff Frost" <[email protected]>:
>>>>> Nice catch! I found a couple other things as well, so here’s an updated version:
>>>>>
>>>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>>>
>>>>> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>>>>>
>>>>>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>>>>>>
>>>>>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>>>>>
>>>>>> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>>>>>> --
>>>>>> Sent via pgsql-pkg-yum mailing list ([email protected])
>>>>>> To make changes to your subscription:
>>>>>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>>>>
>>>>> ---
>>>>> Jeff Frost <[email protected]>
>>>>> CTO, PostgreSQL Experts, Inc.
>>>>> Phone: 1-888-PG-EXPRT x506
>>>>> FAX: 415-762-5122
>>>>> http://www.pgexperts.com/
>>>
>>> ---
>>> Jeff Frost <[email protected]>
>>> CTO, PostgreSQL Experts, Inc.
>>> Phone: 1-888-PG-EXPRT x506
>>> FAX: 415-762-5122
>>> http://www.pgexperts.com/
>
> ---
> Jeff Frost <[email protected]>
> CTO, PostgreSQL Experts, Inc.
> Phone: 1-888-PG-EXPRT x506
> FAX: 415-762-5122
> http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 19:23 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 20:44 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 21:46 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 21:49 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 22:26 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
@ 2015-09-18 23:00 ` Jeff Frost <[email protected]>
2015-09-19 01:10 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Jeff Frost @ 2015-09-18 23:00 UTC (permalink / raw)
To: Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
This should address all your concerns:
http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
> On Sep 18, 2015, at 3:26 PM, Andrew N Golovkov <[email protected]> wrote:
>
> git diff -b: https://bpaste.net/show/89b37acb8f0a
>
> Removed `switch' action, because not supported at least from 3.3.3, where init-script changed in upstream;
>
> Every call stop/start/reload with correct calls and use variable `$PGPOOLUSER'
> Removed unhandled arguments from `failure' and `success' function calls;
> Cleanup useless commands and exit's.
>
> Every line aligned with tabs;
>
> Version in comment is 3.4 as proposed Devrim.
>
> 19.09.2015, 00:50, "Jeff Frost" <[email protected]>:
>> Could you use diff -b so it doesn’t show lines with just whitespace different?
>>
>>> On Sep 18, 2015, at 2:46 PM, Andrew N Golovkov <[email protected]> wrote:
>>>
>>> And again.
>>>
>>> https://bpaste.net/show/20ee48a0fc81
>>>
>>> Diff with your script and my (with little cosmetic changes from previous version).
>>>
>>> 18.09.2015, 23:45, "Jeff Frost" <[email protected]>:
>>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>>
>>>>> On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <[email protected]> wrote:
>>>>>
>>>>> You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
>>>>> Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
>>>>>> $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
>>>>>
>>>>> Please, look at my script i'v posted today.
>>>>>
>>>>> 18.09.2015, 20:17, "Jeff Frost" <[email protected]>:
>>>>>> Nice catch! I found a couple other things as well, so here’s an updated version:
>>>>>>
>>>>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>>>>
>>>>>> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>>>>>>
>>>>>>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>>>>>>>
>>>>>>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>>>>>>
>>>>>>> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>>>>>>> --
>>>>>>> Sent via pgsql-pkg-yum mailing list ([email protected])
>>>>>>> To make changes to your subscription:
>>>>>>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>>>>>
>>>>>> ---
>>>>>> Jeff Frost <[email protected]>
>>>>>> CTO, PostgreSQL Experts, Inc.
>>>>>> Phone: 1-888-PG-EXPRT x506
>>>>>> FAX: 415-762-5122
>>>>>> http://www.pgexperts.com/
>>>>
>>>> ---
>>>> Jeff Frost <[email protected]>
>>>> CTO, PostgreSQL Experts, Inc.
>>>> Phone: 1-888-PG-EXPRT x506
>>>> FAX: 415-762-5122
>>>> http://www.pgexperts.com/
>>
>> ---
>> Jeff Frost <[email protected]>
>> CTO, PostgreSQL Experts, Inc.
>> Phone: 1-888-PG-EXPRT x506
>> FAX: 415-762-5122
>> http://www.pgexperts.com/
---
Jeff Frost <[email protected]>
CTO, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 19:23 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 20:44 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 21:46 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 21:49 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 22:26 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 23:00 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-19 01:10 ` Andrew N Golovkov <[email protected]>
2015-09-19 01:27 ` Re: init script for pgpool Jeff Frost <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Andrew N Golovkov @ 2015-09-19 01:10 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; +Cc: pgsql-pkg-yum
Awesome! Thanks!
19.09.2015, 02:00, "Jeff Frost" <[email protected]>:
> This should address all your concerns:
>
> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>
>> On Sep 18, 2015, at 3:26 PM, Andrew N Golovkov <[email protected]> wrote:
>>
>> git diff -b: https://bpaste.net/show/89b37acb8f0a
>>
>> Removed `switch' action, because not supported at least from 3.3.3, where init-script changed in upstream;
>>
>> Every call stop/start/reload with correct calls and use variable `$PGPOOLUSER'
>> Removed unhandled arguments from `failure' and `success' function calls;
>> Cleanup useless commands and exit's.
>>
>> Every line aligned with tabs;
>>
>> Version in comment is 3.4 as proposed Devrim.
>>
>> 19.09.2015, 00:50, "Jeff Frost" <[email protected]>:
>>> Could you use diff -b so it doesn’t show lines with just whitespace different?
>>>
>>>> On Sep 18, 2015, at 2:46 PM, Andrew N Golovkov <[email protected]> wrote:
>>>>
>>>> And again.
>>>>
>>>> https://bpaste.net/show/20ee48a0fc81
>>>>
>>>> Diff with your script and my (with little cosmetic changes from previous version).
>>>>
>>>> 18.09.2015, 23:45, "Jeff Frost" <[email protected]>:
>>>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>>>
>>>>>> On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <[email protected]> wrote:
>>>>>>
>>>>>> You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
>>>>>> Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
>>>>>>> $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
>>>>>>
>>>>>> Please, look at my script i'v posted today.
>>>>>>
>>>>>> 18.09.2015, 20:17, "Jeff Frost" <[email protected]>:
>>>>>>> Nice catch! I found a couple other things as well, so here’s an updated version:
>>>>>>>
>>>>>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>>>>>
>>>>>>> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>>>>>>>
>>>>>>>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>>>>>>>>
>>>>>>>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>>>>>>>
>>>>>>>> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>>>>>>>> --
>>>>>>>> Sent via pgsql-pkg-yum mailing list ([email protected])
>>>>>>>> To make changes to your subscription:
>>>>>>>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>>>>>>
>>>>>>> ---
>>>>>>> Jeff Frost <[email protected]>
>>>>>>> CTO, PostgreSQL Experts, Inc.
>>>>>>> Phone: 1-888-PG-EXPRT x506
>>>>>>> FAX: 415-762-5122
>>>>>>> http://www.pgexperts.com/
>>>>>
>>>>> ---
>>>>> Jeff Frost <[email protected]>
>>>>> CTO, PostgreSQL Experts, Inc.
>>>>> Phone: 1-888-PG-EXPRT x506
>>>>> FAX: 415-762-5122
>>>>> http://www.pgexperts.com/
>>>
>>> ---
>>> Jeff Frost <[email protected]>
>>> CTO, PostgreSQL Experts, Inc.
>>> Phone: 1-888-PG-EXPRT x506
>>> FAX: 415-762-5122
>>> http://www.pgexperts.com/
>
> ---
> Jeff Frost <[email protected]>
> CTO, PostgreSQL Experts, Inc.
> Phone: 1-888-PG-EXPRT x506
> FAX: 415-762-5122
> http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 19:23 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 20:44 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 21:46 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 21:49 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 22:26 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 23:00 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-19 01:10 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
@ 2015-09-19 01:27 ` Jeff Frost <[email protected]>
2015-09-21 14:14 ` Re: init script for pgpool Devrim GÜNDÜZ <[email protected]>
0 siblings, 1 reply; 22+ messages in thread
From: Jeff Frost @ 2015-09-19 01:27 UTC (permalink / raw)
To: Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
Merged.
It’ll show up in the repo the next time we build packages.
> On Sep 18, 2015, at 6:10 PM, Andrew N Golovkov <[email protected]> wrote:
>
> Awesome! Thanks!
>
> 19.09.2015, 02:00, "Jeff Frost" <[email protected]>:
>> This should address all your concerns:
>>
>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>
>>> On Sep 18, 2015, at 3:26 PM, Andrew N Golovkov <[email protected]> wrote:
>>>
>>> git diff -b: https://bpaste.net/show/89b37acb8f0a
>>>
>>> Removed `switch' action, because not supported at least from 3.3.3, where init-script changed in upstream;
>>>
>>> Every call stop/start/reload with correct calls and use variable `$PGPOOLUSER'
>>> Removed unhandled arguments from `failure' and `success' function calls;
>>> Cleanup useless commands and exit's.
>>>
>>> Every line aligned with tabs;
>>>
>>> Version in comment is 3.4 as proposed Devrim.
>>>
>>> 19.09.2015, 00:50, "Jeff Frost" <[email protected]>:
>>>> Could you use diff -b so it doesn’t show lines with just whitespace different?
>>>>
>>>>> On Sep 18, 2015, at 2:46 PM, Andrew N Golovkov <[email protected]> wrote:
>>>>>
>>>>> And again.
>>>>>
>>>>> https://bpaste.net/show/20ee48a0fc81
>>>>>
>>>>> Diff with your script and my (with little cosmetic changes from previous version).
>>>>>
>>>>> 18.09.2015, 23:45, "Jeff Frost" <[email protected]>:
>>>>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>>>>
>>>>>>> On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <[email protected]> wrote:
>>>>>>>
>>>>>>> You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
>>>>>>> Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
>>>>>>>> $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
>>>>>>>
>>>>>>> Please, look at my script i'v posted today.
>>>>>>>
>>>>>>> 18.09.2015, 20:17, "Jeff Frost" <[email protected]>:
>>>>>>>> Nice catch! I found a couple other things as well, so here’s an updated version:
>>>>>>>>
>>>>>>>> http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.i...
>>>>>>>>
>>>>>>>> It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>>>>>>>>
>>>>>>>>> On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <[email protected]> wrote:
>>>>>>>>>
>>>>>>>>> You forget $pidfile and $PGPOOLUSER and some more comments.
>>>>>>>>>
>>>>>>>>> Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>>>>>>>>> --
>>>>>>>>> Sent via pgsql-pkg-yum mailing list ([email protected])
>>>>>>>>> To make changes to your subscription:
>>>>>>>>> http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>>>>>>>
>>>>>>>> ---
>>>>>>>> Jeff Frost <[email protected]>
>>>>>>>> CTO, PostgreSQL Experts, Inc.
>>>>>>>> Phone: 1-888-PG-EXPRT x506
>>>>>>>> FAX: 415-762-5122
>>>>>>>> http://www.pgexperts.com/
>>>>>>
>>>>>> ---
>>>>>> Jeff Frost <[email protected]>
>>>>>> CTO, PostgreSQL Experts, Inc.
>>>>>> Phone: 1-888-PG-EXPRT x506
>>>>>> FAX: 415-762-5122
>>>>>> http://www.pgexperts.com/
>>>>
>>>> ---
>>>> Jeff Frost <[email protected]>
>>>> CTO, PostgreSQL Experts, Inc.
>>>> Phone: 1-888-PG-EXPRT x506
>>>> FAX: 415-762-5122
>>>> http://www.pgexperts.com/
>>
>> ---
>> Jeff Frost <[email protected]>
>> CTO, PostgreSQL Experts, Inc.
>> Phone: 1-888-PG-EXPRT x506
>> FAX: 415-762-5122
>> http://www.pgexperts.com/
---
Jeff Frost <[email protected]>
CTO, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
* Re: init script for pgpool
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-17 18:38 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 12:40 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 19:23 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 20:44 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 21:46 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 21:49 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-18 22:26 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-18 23:00 ` Re: init script for pgpool Jeff Frost <[email protected]>
2015-09-19 01:10 ` Re: init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-19 01:27 ` Re: init script for pgpool Jeff Frost <[email protected]>
@ 2015-09-21 14:14 ` Devrim GÜNDÜZ <[email protected]>
0 siblings, 0 replies; 22+ messages in thread
From: Devrim GÜNDÜZ @ 2015-09-21 14:14 UTC (permalink / raw)
To: Jeff Frost <[email protected]>; Andrew N Golovkov <[email protected]>; +Cc: pgsql-pkg-yum
Hi,
On Fri, 2015-09-18 at 18:27 -0700, Jeff Frost wrote:
> Merged.
Thanks!
> It’ll show up in the repo the next time we build packages.
Just pushed them to 9.4, 9.3, 9.2 and 9.1 repos. Thanks again for the
patch.
Regards,
--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 22+ messages in thread
end of thread, other threads:[~2015-09-21 14:14 UTC | newest]
Thread overview: 22+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2015-09-14 13:00 init script for pgpool Andrew N Golovkov <[email protected]>
2015-09-15 04:20 ` Jeff Frost <[email protected]>
2015-09-15 05:27 ` Devrim GÜNDÜZ <[email protected]>
2015-09-16 00:28 ` Jeff Frost <[email protected]>
2015-09-16 08:25 ` Devrim GÜNDÜZ <[email protected]>
2015-09-16 15:18 ` Jeff Frost <[email protected]>
2015-09-16 17:17 ` Devrim GÜNDÜZ <[email protected]>
2015-09-17 18:38 ` Jeff Frost <[email protected]>
2015-09-18 12:40 ` Andrew N Golovkov <[email protected]>
2015-09-18 17:17 ` Jeff Frost <[email protected]>
2015-09-18 17:27 ` Devrim Gündüz <[email protected]>
2015-09-18 17:33 ` Jeff Frost <[email protected]>
2015-09-18 18:04 ` Devrim GÜNDÜZ <[email protected]>
2015-09-18 19:23 ` Andrew N Golovkov <[email protected]>
2015-09-18 20:44 ` Jeff Frost <[email protected]>
2015-09-18 21:46 ` Andrew N Golovkov <[email protected]>
2015-09-18 21:49 ` Jeff Frost <[email protected]>
2015-09-18 22:26 ` Andrew N Golovkov <[email protected]>
2015-09-18 23:00 ` Jeff Frost <[email protected]>
2015-09-19 01:10 ` Andrew N Golovkov <[email protected]>
2015-09-19 01:27 ` Jeff Frost <[email protected]>
2015-09-21 14:14 ` Devrim GÜNDÜZ <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox