pg.ddx.io  pgsql-rrreviewers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Euler Taveira de Oliveira <euler@timbira.com>
To: Andy Colson <andy@squeakycode.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Cc: pgsql-rrreviewers@postgresql.org
Subject: Re: [HACKERS] reviewers needed!
Date: Sun, 16 Jan 2011 18:13:30 -0300
Message-ID: <4D335F7A.7010906@timbira.com> (raw)
In-Reply-To: <4D334772.9070709@squeakycode.net>
References: <AANLkTinMrK=f7QDVfB8-KwWsCv-4a4ohbf4u4bHxvAjo@mail.gmail.com>
	<4D334772.9070709@squeakycode.net>

Em 16-01-2011 16:30, Andy Colson escreveu:
> I reviewed a couple patched, and I added my review to the commitfest page.
>
> If I find a problem, its obvious I should mark the patch as "returned
> with feedback".
>
> But what if I'm happy with it? I'm not a hacker so cannot do C code
> review, should I leave it alone? Mark it as "ready for committer"?
>
Did you take a look at [1]? If your patch involves C code and you're not C 
proficient then there must be another reviewer to give his/her opinion (of 
course, the other person could be the committer). I wouldn't mark it "ready 
for committer" instead leave it as is ("needs review"); just be sure to add 
your comments in the commitfest app.


[1] http://wiki.postgresql.org/wiki/RRReviewers


-- 
   Euler Taveira de Oliveira
   http://www.timbira.com/



view thread (14+ messages)  latest in thread

Message-ID: <4D335F7A.7010906@timbira.com>
Permalink:  ../4D335F7A.7010906@timbira.com/
Also on:    postgresql.org/message-id/4D335F7A.7010906@timbira.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-rrreviewers@postgresql.org
  Cc: euler@timbira.com, andy@squeakycode.net, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [HACKERS] reviewers needed!
  In-Reply-To: <4D335F7A.7010906@timbira.com>
  References: <AANLkTinMrK=f7QDVfB8-KwWsCv-4a4ohbf4u4bHxvAjo@mail.gmail.com> <4D334772.9070709@squeakycode.net> <4D335F7A.7010906@timbira.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox