pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <maillist@candle.pha.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jim Rowan <jmr@computing.com>
Cc: Jan Wieck <jwieck@debis.com>
Cc: Olivier Ertz <ertz@illite.u-strasbg.fr>
Cc: pgsql-sql@postgreSQL.org
Subject: Re: [SQL] RewriteDefine.c : Rule size
Date: Fri, 9 Jul 1999 12:56:57 -0400 (EDT)
Message-ID: <199907091656.MAA01689@candle.pha.pa.us> (raw)
In-Reply-To: <2314.931530245@sss.pgh.pa.us>

> There is a poorly-documented restriction that BLCKSZ can't exceed 32K
> (IIRC, this is because block offsets are stored in signed shorts somewhere).
> Probably would be a good idea to mention this in the comments in
> config.h.in.
> 
> For the long run it would be nice to remove the restriction.  I have no
> idea whether that would be easy or hard.  Ideally we could do something
> like
> 
> #if BLCKSZ > 32767
> 	typedef int BlockOffset;
> #else
> 	typedef short BlockOffset;
> #endif
> 
> but finding all the places that need to use the typedef might be a pain.

Added comment to config.h.in, and TODO item:

	* Allow BLCKSZ <= 64k, not <= 32k

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026



view thread (6+ messages)

Message-ID: <199907091656.MAA01689@candle.pha.pa.us>
Permalink:  ../199907091656.MAA01689@candle.pha.pa.us/
Also on:    postgresql.org/message-id/199907091656.MAA01689@candle.pha.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: maillist@candle.pha.pa.us, tgl@sss.pgh.pa.us, jmr@computing.com, jwieck@debis.com, ertz@illite.u-strasbg.fr
  Subject: Re: [SQL] RewriteDefine.c : Rule size
  In-Reply-To: <199907091656.MAA01689@candle.pha.pa.us>
  References: <2314.931530245@sss.pgh.pa.us> <199907091656.MAA01689@candle.pha.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox