pg.ddx.io  pgsql-sql@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jim Rowan <jmr@computing.com>
Cc: jwieck@debis.com
Cc: ertz@illite.u-strasbg.fr
Cc: pgsql-sql@postgreSQL.org
Subject: Re: [SQL] RewriteDefine.c : Rule size
Date: Fri, 09 Jul 1999 10:24:05 -0400
Message-ID: <2314.931530245@sss.pgh.pa.us> (raw)
In-Reply-To: <199907090425.XAA12140@zee.computing.com>

Jim Rowan <jmr@computing.com> writes:
> First we multiplied it * 4.  This improved the ability to handle complex
> rules, but didn't go far enough... (it still wouldn't handle all of what we
> wanted it to). 

> So we multiplied it * 8.  Initdb complained about "float4 not
> defined".

There is a poorly-documented restriction that BLCKSZ can't exceed 32K
(IIRC, this is because block offsets are stored in signed shorts somewhere).
Probably would be a good idea to mention this in the comments in
config.h.in.

For the long run it would be nice to remove the restriction.  I have no
idea whether that would be easy or hard.  Ideally we could do something
like

#if BLCKSZ > 32767
	typedef int BlockOffset;
#else
	typedef short BlockOffset;
#endif

but finding all the places that need to use the typedef might be a pain.

			regards, tom lane



view thread (6+ messages)  latest in thread

Message-ID: <2314.931530245@sss.pgh.pa.us>
Permalink:  ../2314.931530245@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2314.931530245@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-sql@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jmr@computing.com, jwieck@debis.com, ertz@illite.u-strasbg.fr
  Subject: Re: [SQL] RewriteDefine.c : Rule size
  In-Reply-To: <2314.931530245@sss.pgh.pa.us>
  References: <199907090425.XAA12140@zee.computing.com> <2314.931530245@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox