From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Stas Kelvich <stas.kelvich@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: pgsql-students@postgresql.org
Subject: Re: [HACKERS] Cube extension point support // GSoC'13
Date: Mon, 21 Oct 2013 15:41:16 -0400
Message-ID: <3819.1382384476@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfduVqAv7M4HO4RqEESTaC1zZ+wkCc-GtdGD++02FiGEunQ@mail.gmail.com>
References: <23364502-F542-4553-A658-4D3A2B6FCFA9@gmail.com>
<5236A9BC.3030000@vmware.com>
<EF7A0879-4E83-4AAE-997D-222D6761E1C6@gmail.com>
<CA+TgmoZdaou7E9wBApexPkYvOiEKBW2Xp8+G6rNFYxav8gVT4Q@mail.gmail.com>
<5258038C.9070409@vmware.com>
<CAPpHfdu-6COA6VA+50Q9cF=rEGn3DnzvhnUjbkpqXj4m_1zAVg@mail.gmail.com>
<52657B1C.7050906@vmware.com>
<CAPpHfduVqAv7M4HO4RqEESTaC1zZ+wkCc-GtdGD++02FiGEunQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-students>
Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Mon, Oct 21, 2013 at 11:06 PM, Heikki Linnakangas <
> hlinnakangas@vmware.com> wrote:
>> I guess it can't happen. Or is it possible that a toasted value that came
>> from disk will be passed to these functions, without detoasting them
>> somewhere along the way? Not sure.
> I will ask Teodor about it. When situation will be completely clear we
> should cleanup confusing comments.
I believe the reason GIST has compress/decompress functions is not for
TOAST (they predate that, if memory serves), but to allow the on-disk
representation of an index entry to be different from the data type's
normal representation in other ways --- think lossy storage in particular.
It's possible that the code in cube's decompress/decompress functions is
unnecessary because cube doesn't actually do any such compression; the
code might've been copy-pasted from somewhere else without adequate
thought about whether it was useful for cubes. I'd want to see some
discussion about why it's okay to change it before we do so, though.
In any case it seems separate from the claimed purpose of this patch
and thus better done in a different patch.
regards, tom lane
--
Sent via pgsql-students mailing list (pgsql-students@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-students
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-students@postgresql.org
Cc: tgl@sss.pgh.pa.us, aekorotkov@gmail.com, hlinnakangas@vmware.com, stas.kelvich@gmail.com, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] Cube extension point support // GSoC'13
In-Reply-To: <3819.1382384476@sss.pgh.pa.us>
References: <23364502-F542-4553-A658-4D3A2B6FCFA9@gmail.com> <5236A9BC.3030000@vmware.com> <EF7A0879-4E83-4AAE-997D-222D6761E1C6@gmail.com> <CA+TgmoZdaou7E9wBApexPkYvOiEKBW2Xp8+G6rNFYxav8gVT4Q@mail.gmail.com> <5258038C.9070409@vmware.com> <CAPpHfdu-6COA6VA+50Q9cF=rEGn3DnzvhnUjbkpqXj4m_1zAVg@mail.gmail.com> <52657B1C.7050906@vmware.com> <CAPpHfduVqAv7M4HO4RqEESTaC1zZ+wkCc-GtdGD++02FiGEunQ@mail.gmail.com> <3819.1382384476@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox