pg.ddx.io  pgsql-testers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: oleg@sai.msu.su, Denis de Bernardy <ddebernardy@yahoo.com>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-bugs@postgresql.org
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Date: Sat, 02 Jul 2011 18:21:22 -0700
Message-ID: <1309656082.3012.13.camel@jdavis> (raw)
In-Reply-To: <21086.1309646333@sss.pgh.pa.us>
References: <4DF81BA0.3000601@archidevsys.co.nz>
	<743036.48052.qm@web112401.mail.gq1.yahoo.com>
	<366790.65150.qm@web112414.mail.gq1.yahoo.com>
	<BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com>
	<1308428403.2597.66.camel@jdavis>
	<1308504190.2597.71.camel@jdavis>
	<21086.1309646333@sss.pgh.pa.us>

On Sat, 2011-07-02 at 18:38 -0400, Tom Lane wrote:
> Quite honestly, I think that the bug is that btree_gist took it upon
> itself to invent <> as an indexable operator.

Well, it was following documentation that any extension could
potentially use. I think it's a stretch to call it a bug in anything
other than postgres.

So I think we'd need to introduce extra documentation to say that at
most one of an operator and its negator can be indexable; and we should
add a check to prevent that as well.

>   The odds that that will
> ever be of practical use seem negligible, and not at all adequate to
> warrant adding extra cycles into mainstream code paths.  It's not too
> late to rip that out of 9.1, and that's what I think we should do.

Fair enough. I think it was kind of an interesting use case, and there
might be others like it; but I agree that it wasn't particularly
compelling.

The alternatives don't seem very attractive. To get it to work with one
lookup we'd have to either clutter the btree opclasses with "<>", or
invent a new syscache that has the AM as a key so we can filter out
non-btree opclasses.

I suppose this is another argument for type interfaces.

Regards,
	Jeff Davis




view thread (10+ messages)  latest in thread

Message-ID: <1309656082.3012.13.camel@jdavis>
Permalink:  ../1309656082.3012.13.camel@jdavis/
Also on:    postgresql.org/message-id/1309656082.3012.13.camel@jdavis

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-testers@postgresql.org
  Cc: pgsql@j-davis.com, tgl@sss.pgh.pa.us, ddebernardy@yahoo.com, teodor@sigaev.ru, pgsql-bugs@postgresql.org
  Subject: Re: PG regression with row comparison when btree_gist is enabled (BUG)
  In-Reply-To: <1309656082.3012.13.camel@jdavis>
  References: <4DF81BA0.3000601@archidevsys.co.nz> <743036.48052.qm@web112401.mail.gq1.yahoo.com> <366790.65150.qm@web112414.mail.gq1.yahoo.com> <BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com> <1308428403.2597.66.camel@jdavis> <1308504190.2597.71.camel@jdavis> <21086.1309646333@sss.pgh.pa.us> <1309656082.3012.13.camel@jdavis>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox