pg.ddx.io  pgsql-testers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: oleg@sai.msu.su, Denis de Bernardy <ddebernardy@yahoo.com>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-bugs@postgresql.org
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Date: Tue, 05 Jul 2011 13:56:21 -0400
Message-ID: <21432.1309888581@sss.pgh.pa.us> (raw)
In-Reply-To: <1309886656.3012.83.camel@jdavis>
References: <4DF81BA0.3000601@archidevsys.co.nz>
	<743036.48052.qm@web112401.mail.gq1.yahoo.com>
	<366790.65150.qm@web112414.mail.gq1.yahoo.com>
	<BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com>
	<1308428403.2597.66.camel@jdavis>
	<1308504190.2597.71.camel@jdavis>
	<21086.1309646333@sss.pgh.pa.us>
	<1309886656.3012.83.camel@jdavis>

Jeff Davis <pgsql@j-davis.com> writes:
> I think that ripping out the change to btree_gist is also insufficient;
> we would also have to prevent other extensions from doing the same. That
> means documenting an odd special case, and testing for it when defining
> an opclass. And then we'd probably have to backpatch this kludge.

There is that.  I doubt it's worth back-patching, though.

> Something simpler seems possible here. The root of the problem is that
> we're being fooled by GiST opclasses when all we care about are BTree
> opclasses anyway. A simple fix would be to introduce a flag
> "found_btree_op". If we hit any BTree entries from pg_amop at all, then
> we're done after the loop is done. If not, then we negate the op and
> loop again.

Yeah, I had been thinking along the same lines.  It will require
duplicating the search loop, which is a bit annoying, but perhaps that
could be factored out as a subroutine.

			regards, tom lane



view thread (10+ messages)  latest in thread

Message-ID: <21432.1309888581@sss.pgh.pa.us>
Permalink:  ../21432.1309888581@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/21432.1309888581@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-testers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, ddebernardy@yahoo.com, teodor@sigaev.ru, pgsql-bugs@postgresql.org
  Subject: Re: PG regression with row comparison when btree_gist is enabled (BUG)
  In-Reply-To: <21432.1309888581@sss.pgh.pa.us>
  References: <4DF81BA0.3000601@archidevsys.co.nz> <743036.48052.qm@web112401.mail.gq1.yahoo.com> <366790.65150.qm@web112414.mail.gq1.yahoo.com> <BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com> <1308428403.2597.66.camel@jdavis> <1308504190.2597.71.camel@jdavis> <21086.1309646333@sss.pgh.pa.us> <1309886656.3012.83.camel@jdavis> <21432.1309888581@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox