public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Guillaume Lelarge <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: PostgreSQL www <[email protected]>
Subject: Re: Patch to make some strings available to translations
Date: Thu, 27 Mar 2008 11:43:24 +0100
Message-ID: <20080327114324.71ed6bd5@mha-laptop> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<20080326223645.6ea671b1@mha-laptop>
	<[email protected]>

Guillaume Lelarge wrote:
> Magnus Hagander a écrit :
> > On Sat, 22 Mar 2008 22:52:17 +0100
> > Guillaume Lelarge <[email protected]> wrote:
> > 
> >> Alvaro Herrera a écrit :
> >>> Guillaume Lelarge wrote:
> >>>
> >>>>> I guess I was wrong. You'll find a patch attached that
> >>>>> implements a func_image function via a call to
> >>>>> setCallbackFunction.
> >>>>>
> >>>>> I can also send a complete patch (the previous one which adds  
> >>>>> translation to some texts, and this patch).
> >>> Suggestion: check if the image exists in the translated version,
> >>> serve the english version if not.  That way you only need to
> >>> produce alternate images for those that need translation.
> >>>
> >> Damn, forgot about this one. You're right. Patch version 2
> >> attached.
> > 
> > Applied, thanks.
> > 
> 
> Thanks a lot.
> 
> > Can you please re-send the patch with the other translation stuff?
> > I've managed to mess up the different versions of it so I'm no
> > longer sure I'm working off the correct one :-(
> > 
> 
> Here it is. Thanks for looking at it.
> 
> 
> -- 
> Guillaume.
>   http://www.postgresqlfr.org
>   http://dalibo.com


This patch no longer applies :-(

The change to pgpage.php was in your other patch.

There's a whole bunch of conflicts in index.html.

Also, the page as generated does not come out as XHTML valid. This is
because you changed it to use ' instead of " for some attributes, and
when there is ' in the text (The world's most advanced...), the HTML is
broken. I'd really like a way to keep the "s on the tags instead of ',
so please see if you can find some way for that :-)

//Magnus

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Patch to make some strings available to translations
  In-Reply-To: <20080327114324.71ed6bd5@mha-laptop>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox