From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Subject: Re: Bogus reports from coverage.postgresql.org
Date: Tue, 13 Mar 2018 13:01:05 -0400
Message-ID: <20180313170105.GC2416@tamriel.snowman.net> (raw)
In-Reply-To: <13148.1520798486@sss.pgh.pa.us>
References: <d0eec0fd-bf3b-55da-f5de-4fa1c00ce400@2ndquadrant.com>
<CABUevEyydszbZJPF6iyjU45C+Kx4YSCa+KDZJkXNdjiGbE0Ojg@mail.gmail.com>
<30195.1520790475@sss.pgh.pa.us>
<30669.1520791101@sss.pgh.pa.us>
<CABUevEx5Q0YEPrsdUL75BB0z+Ns3m7eX=x3oRwttjHRJ0HeQRw@mail.gmail.com>
<31446.1520791925@sss.pgh.pa.us>
<1594.1520795000@sss.pgh.pa.us>
<2633.1520796277@sss.pgh.pa.us>
<bc1608e2-41ad-4c07-f939-e165944eb163@2ndquadrant.com>
<13148.1520798486@sss.pgh.pa.us>
Greetings,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > I tried it on Debian stable with gcc 6.3.0 and couldn't reproduce it.
> > cc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
>
> Oh ... *that's* interesting. Are we sure this is the version in use
> on coverage.postgresql.org?
Yes, it's the same, but this isn't a gcov issue, I don't think.
> Also, I just finished searching in vain for any plausibly-matching
> bug at https://gcc.gnu.org/bugzilla/. I did find a few reports
> suggesting that gcov could misbehave with nondefault build options
> such as LTO. And "gcov -a" has also had issues. So maybe we ought
> to have a look at exactly what coverage.postgresql.org's build
> recipe is.
Running gcov on the box itself in the source dir shows the same results
which you got:
---
-: 487: }
#####: 488: break;
-: 489: }
-: 490:
-: 491: /* can't get here */
#####: 492: elog(ERROR, "predicate_classify returned a bogus value");
-: 493: return false;
-: 494:}
---
Which seems to indicate that this actually is some kind of lcov bug.
That makes more sense too since lcov is 1.13 on coverage.p.o, but you
used 1.10 and said you didn't see an issue. Not sure if you have access
to 1.13 easily, but if so, could be useful to see if you're seeing the
same behavior under 1.13 where the gcov output is correct but lcov
output isn't.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20180313170105.GC2416@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-www@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, magnus@hagander.net, pgsql-www@lists.postgresql.org
Subject: Re: Bogus reports from coverage.postgresql.org
In-Reply-To: <20180313170105.GC2416@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox