From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Subject: Re: Bogus reports from coverage.postgresql.org
Date: Tue, 13 Mar 2018 16:30:51 -0400
Message-ID: <963.1520973051@sss.pgh.pa.us> (raw)
In-Reply-To: <20180313170105.GC2416@tamriel.snowman.net>
References: <d0eec0fd-bf3b-55da-f5de-4fa1c00ce400@2ndquadrant.com>
<CABUevEyydszbZJPF6iyjU45C+Kx4YSCa+KDZJkXNdjiGbE0Ojg@mail.gmail.com>
<30195.1520790475@sss.pgh.pa.us>
<30669.1520791101@sss.pgh.pa.us>
<CABUevEx5Q0YEPrsdUL75BB0z+Ns3m7eX=x3oRwttjHRJ0HeQRw@mail.gmail.com>
<31446.1520791925@sss.pgh.pa.us>
<1594.1520795000@sss.pgh.pa.us>
<2633.1520796277@sss.pgh.pa.us>
<bc1608e2-41ad-4c07-f939-e165944eb163@2ndquadrant.com>
<13148.1520798486@sss.pgh.pa.us>
<20180313170105.GC2416@tamriel.snowman.net>
Stephen Frost <sfrost@snowman.net> writes:
> Which seems to indicate that this actually is some kind of lcov bug.
> That makes more sense too since lcov is 1.13 on coverage.p.o, but you
> used 1.10 and said you didn't see an issue. Not sure if you have access
> to 1.13 easily, but if so, could be useful to see if you're seeing the
> same behavior under 1.13 where the gcov output is correct but lcov
> output isn't.
Hpmh. So I tested Fedora 26, which has lcov 1.12, and that seems fine.
Then I installed pre-release Fedora 28, which has lcov 1.13, and that
does not work at all:
$ make coverage-html
/usr/bin/lcov --gcov-tool /usr/bin/gcov -q --no-external -c -i -d . -d . -o lcov_base.info
geninfo: WARNING: /home/tgl/pgsql/src/backend/catalog/aclchk.gcno: Overlong record at end of file!
geninfo: WARNING: /home/tgl/pgsql/src/backend/catalog/pg_subscription.gcno: Overlong record at end of file!
geninfo: WARNING: /home/tgl/pgsql/src/backend/catalog/pg_db_role_setting.gcno: Overlong record at end of file!
... lots more ...
geninfo: WARNING: /home/tgl/pgsql/src/backend/storage/lmgr/predicate.gcno: Overlong record at end of file!
geninfo: ERROR: /home/tgl/pgsql/src/backend/storage/lmgr/lwlocknames.gcno: reached unexpected end of file
make: *** [src/Makefile.global:911: lcov_base.info] Error 255
make: *** Deleting file 'lcov_base.info'
Eyeing the commit history at
https://github.com/linux-test-project/lcov/commits/master
makes it appear that lcov doesn't work with gcc 8.0 yet
(well, they committed support last week, but there's no
release yet). So this is basically Fedora breakage ...
but it means I don't have an easy way to check 1.13 except
by installing handmade packages, which would probably
not be definitive proof one way or the other.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-www@postgresql.org
Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, peter.eisentraut@2ndquadrant.com, magnus@hagander.net, pgsql-www@lists.postgresql.org
Subject: Re: Bogus reports from coverage.postgresql.org
In-Reply-To: <963.1520973051@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox