agora inbox for pljava-dev@postgresql.org
help / color / mirror / Atom feedSubject: [Pljava-dev] Patch for SQLInput implementation
Date: Fri, 22 Sep 2006 17:46:42 +0200
Message-ID: <45140562.9070003@logix-tt.com> (raw)
In-Reply-To: <4513F639.3000108@tada.se>
References: <4512F5E4.9060600@logix-tt.com>
<45139C17.3050006@tada.se>
<4513A107.4060809@logix-tt.com>
<4513A3ED.3050401@tada.se>
<4513E2C0.3050804@logix-tt.com>
<4513E52B.5080108@tada.se>
<4513F1A0.8020800@logix-tt.com>
<4513F639.3000108@tada.se>
Hi, Thomas,
Here's my first attempt for the SQLInput side. (I did not live-test it,
and I possibly broke your formatting wr/t tabs/spaces.)
It fetches the Endianness from ByteOrder, and changes readShort(),
readInt() and readLong() accordingly.
I also refactored the readBytes() method to use readShort() internally
for the length tag (or should we change the length to int, while we're
at it?)
Additionally, I added some missing m_handle checks, and moved the
m_position check into the synchronized block at read() (which is
necessary from my understanding of the java memory model, as position
and chunkSize are both not volatile).
Could you have a quick look at it?
The SQLOutput side will follow soon. :-)
Markus
--
Markus Schaber | Logical Tracking&Tracing International AG
Dipl. Inf. | Software Development GIS
Fight against software patents in Europe! www.ffii.org
www.nosoftwarepatents.org
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SQLInput.diff
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20060922/96f99770/attachment.ksh;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20060922/96f99770/attachment.bin;
Message-ID: <45140562.9070003@logix-tt.com>
Permalink: ../45140562.9070003@logix-tt.com/
Also on: postgresql.org/message-id/45140562.9070003@logix-tt.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pljava-dev@postgresql.org
Subject: Re: [Pljava-dev] Patch for SQLInput implementation
In-Reply-To: <45140562.9070003@logix-tt.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox