public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chapman Flack <[email protected]>
To: Kartik Ohri <[email protected]>
Cc: [email protected]
Subject: Re: ScriptingMojo Custom Packaging
Date: Thu, 20 Aug 2020 23:28:01 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAASLQ4P-VeZK46t=PvYw0F05AxqG5i80GTwg2LMhCnjC9WzoZA@mail.gmail.com>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
	<[email protected]>
	<CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com>
	<[email protected]>
	<CAASLQ4M3pR+ZL+uPvcQ-dAEL2KdH_PGe-_pBhsjvOgN5qvf+aA@mail.gmail.com>
	<[email protected]>
	<CAASLQ4NU9v=nuLDG-LneC68LuqKRXchFckU7mCZT9YQDNKqwvg@mail.gmail.com>
	<[email protected]>
	<CAASLQ4NgH+tXbdUSA8xDh2ct3gAS3xa8V7=E0gcYd+d=m8kujw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAASLQ4PEgo5Nj0EVsOfGoB96dQFXfFYxrrB0rS1wdad7x_E5fA@mail.gmail.com>
	<CAASLQ4OowXOmnbbbT0Wh1ZkB4h=6JQfC61ojmN07EYnO0QCcow@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAASLQ4P-VeZK46t=PvYw0F05AxqG5i80GTwg2LMhCnjC9WzoZA@mail.gmail.com>

On 08/20/20 13:00, Kartik Ohri wrote:
> I have made these changes
> https://github.com/amCap1712/pljava/commit/14045b10ca1428fc2914440a2220871ac7c9921b
> but the build process fails with this error
> https://gist.github.com/amCap1712/ad9fe94fd9fb6f4ff4f26913a464c226. I
> checked the jar files manually to make sure the file is present in it. The
> pgxs jar is also listed in the lists of url classpaths.

Hmm ... for me it does not even get that far:

[ERROR] Unknown packaging: pgxs @
org.postgresql:pljava-so:[unknown-version],
/var/tmp/nohome/pljava/pljava-so/pom.xml, line 14, column 13

It seems to be an issue similar to what we had with the profiles before,
referring to a plugin that had not yet been built. Perhaps in your case
it got further because the plugin had been built in an earlier step?

This might make the custom-packaging idea unworkable without a multi-step
build, which I would really rather avoid. Maybe the packaging type
for pljava-so should just be changed from nar to whichever of the
predefined packaging types will impose the fewest extraneous expectations.
Maybe that's pom. It only binds two phases and doesn't assume there is
anything to produce besides the pom file, which is already there.
We'll produce the .so or .dll or .bundle also, but Maven doesn't need
to care.

The custom type seemed more satisfying to me, but not if it ties things
in knots.

Regards,
-Chap

view thread (78+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: ScriptingMojo Custom Packaging
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox