public inbox for [email protected]  
help / color / mirror / Atom feed
From: Kartik Ohri <[email protected]>
To: Chapman Flack <[email protected]>
Cc: [email protected]
Subject: Re: PL/Java new build plugin
Date: Wed, 15 Jul 2020 16:57:32 +0530
Message-ID: <CAASLQ4O8NuO_umcCFBOJNUMKfNVrrdBjdDGc3ttpb=L-oOooiA@mail.gmail.com> (raw)
In-Reply-To: <CAASLQ4P+zUuWvpXb9U_CDY384P=sSNP0ATYCb0nf1d=sbt5TjA@mail.gmail.com>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
	<CAASLQ4PEe0_1dE-iOBv27fX1SUH0=ewDm=6w9chHLjWSAkeNgQ@mail.gmail.com>
	<[email protected]>
	<CAASLQ4MLFd6zhoh+sWWz+iu4d8+H2ML+y=kL990k7H=kk74pvA@mail.gmail.com>
	<[email protected]>
	<CAASLQ4Ms0QGf-Qh966HrsoaWzwf1SYHZ0WmZHApQePbcyPejCQ@mail.gmail.com>
	<CAASLQ4NFHYH1pfGJtCZDfdcxf_ZzLA+X+ko86vpyRDKVYr489Q@mail.gmail.com>
	<[email protected]>
	<CAASLQ4PDcaAJ8fEwXXFW6XPakc7GCNVgPNGCxA8KYMzPDZw4+w@mail.gmail.com>
	<[email protected]>
	<CAASLQ4OuFQCiSMeypQtfRaAvj-4H-EAgszLwdAo6Tc1zS9B66g@mail.gmail.com>
	<[email protected]>
	<CAASLQ4PSizkzBKyyfkp9ccJ1qDPLRLu6g2bo9cN-XuTzGQFGfQ@mail.gmail.com>
	<CAASLQ4P9zGxHda=HAGJ2eAa-oMmJtnPm=4a14mj4P-QpfFsYxg@mail.gmail.com>
	<[email protected]>
	<CAASLQ4NmornyOW8n-qyneLpDVPgV0Js=+=Eys6bw3Y-ZiVbVjA@mail.gmail.com>
	<CAASLQ4OYvTQL7ssG4=QyEqhaB71=AM-svBUYj3uRdWXWoQgBPw@mail.gmail.com>
	<[email protected]>
	<CAASLQ4P+zUuWvpXb9U_CDY384P=sSNP0ATYCb0nf1d=sbt5TjA@mail.gmail.com>

>
> Even though pg_config explicitly writes
>> a single \n character on every platform, Windows (probably the C library
>> really) still changes it to \r\n before it arrives on the pipe.
>
> This was indeed the case. I also confirmed with a C dev in ##c and they
said that C changes \n to \r\n on Windows. I have fixed this issue. There
is no longer any include path error. There was another error related nar
maven which I was able to fix by setting PGSQL_PKGLIBDIR in addition to
other variables. The plugin now works on windows as well.

I had suspected the same but didn't test it due to some reason I seem to
> have forgotten but I will do that now.
>
This has been also fixed by replacing PG=9 with PG=9.6. I chose 9.6 because
it is the only 9.x PG available in appveyor. If we want to test against any
other 9.x PG, then we need to install it separately.


view thread (132+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: PL/Java new build plugin
  In-Reply-To: <CAASLQ4O8NuO_umcCFBOJNUMKfNVrrdBjdDGc3ttpb=L-oOooiA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox