public inbox for [email protected]
help / color / mirror / Atom feedServer specific advanced config file for testsuite
7+ messages / 3 participants
[nested] [flat]
* Server specific advanced config file for testsuite
@ 2016-09-12 17:26 Navnath Gadakh <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Navnath Gadakh @ 2016-09-12 17:26 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Kanchan Mohitey <[email protected]>; pgadmin-hackers
Hi Dave,
As we know that, we are using two JSON files one is for basic
configuration of server(test_config.json) and second for detailed
configuration of server(test_advanced_config.json).
In test_advanced_config.json, we give detail for database, schema,
extension, collation etc. These details are generic I mean these details
are not server specific.
- Do we need to allow user to give server specific details?
If yes, there should be some identification(like ‘server_type’, ‘version’)
for each detail so that we can read server appropriate details.
We have one approach in mind, to attach 'server_type' & 'version' to each
detail
So, modified test_advanced_config.json can be like this,
{
"add_database_data”:[
{
"conn_limit": -1,
“owner”: “postres”,
.
.
.
.
“server_type”: “pg”,
“version”: “pg9.4”
},
{
{
"conn_limit": -1,
“owner”: “enterprisedb”,
.
.
.
.
“server_type”: “ppas”,
“version”: “ppas9.6”
}
}],
“schema_credentials”:
[{"func_acl": [],
"seq_acl": [],
.
.
.
.
“server_type”: “pg”,
“version”: “pg9.4”
}]
.
.
.
.
.
}
Any suggestions?
For multiple server currently we used 'owner' to identify the server, but
that fails if two servers have the same owner.
--
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Server specific advanced config file for testsuite
@ 2016-09-13 08:48 Dave Page <[email protected]>
parent: Navnath Gadakh <[email protected]>
0 siblings, 2 replies; 7+ messages in thread
From: Dave Page @ 2016-09-13 08:48 UTC (permalink / raw)
To: Navnath Gadakh <[email protected]>; +Cc: Kanchan Mohitey <[email protected]>; pgadmin-hackers
Hi
On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
<[email protected]> wrote:
> Hi Dave,
> As we know that, we are using two JSON files one is for basic
> configuration of server(test_config.json) and second for detailed
> configuration of server(test_advanced_config.json).
> In test_advanced_config.json, we give detail for database, schema,
> extension, collation etc. These details are generic I mean these details are
> not server specific.
> - Do we need to allow user to give server specific details?
I don't see any reason to do so. Honestly I don't see much need for
test_advanced_config.json at all - I can't see anyone ever customising
the tests. I certainly doubt I will.
> If yes, there should be some identification(like ‘server_type’, ‘version’)
> for each detail so that we can read server appropriate details.
> We have one approach in mind, to attach 'server_type' & 'version' to each
> detail
> So, modified test_advanced_config.json can be like this,
> {
> "add_database_data”:[
> {
> "conn_limit": -1,
> “owner”: “postres”,
> .
> .
> .
> .
> “server_type”: “pg”,
> “version”: “pg9.4”
> },
> {
> {
> "conn_limit": -1,
> “owner”: “enterprisedb”,
> .
> .
> .
> .
> “server_type”: “ppas”,
> “version”: “ppas9.6”
> }
> }],
> “schema_credentials”:
> [{"func_acl": [],
> "seq_acl": [],
> .
> .
> .
> .
> “server_type”: “pg”,
> “version”: “pg9.4”
> }]
> .
> .
> .
> .
> .
> }
>
> Any suggestions?
>
> For multiple server currently we used 'owner' to identify the server, but
> that fails if two servers have the same owner.
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Server specific advanced config file for testsuite
@ 2016-09-13 08:48 Dave Page <[email protected]>
parent: Dave Page <[email protected]>
1 sibling, 1 reply; 7+ messages in thread
From: Dave Page @ 2016-09-13 08:48 UTC (permalink / raw)
To: Navnath Gadakh <[email protected]>; +Cc: Kanchan Mohitey <[email protected]>; pgadmin-hackers
BTW - I need the updated code that fixes all outstanding issues this
week please. Release is coming up fast...
On Tue, Sep 13, 2016 at 9:48 AM, Dave Page <[email protected]> wrote:
> Hi
>
> On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
> <[email protected]> wrote:
>> Hi Dave,
>> As we know that, we are using two JSON files one is for basic
>> configuration of server(test_config.json) and second for detailed
>> configuration of server(test_advanced_config.json).
>> In test_advanced_config.json, we give detail for database, schema,
>> extension, collation etc. These details are generic I mean these details are
>> not server specific.
>> - Do we need to allow user to give server specific details?
>
> I don't see any reason to do so. Honestly I don't see much need for
> test_advanced_config.json at all - I can't see anyone ever customising
> the tests. I certainly doubt I will.
>
>> If yes, there should be some identification(like ‘server_type’, ‘version’)
>> for each detail so that we can read server appropriate details.
>> We have one approach in mind, to attach 'server_type' & 'version' to each
>> detail
>> So, modified test_advanced_config.json can be like this,
>> {
>> "add_database_data”:[
>> {
>> "conn_limit": -1,
>> “owner”: “postres”,
>> .
>> .
>> .
>> .
>> “server_type”: “pg”,
>> “version”: “pg9.4”
>> },
>> {
>> {
>> "conn_limit": -1,
>> “owner”: “enterprisedb”,
>> .
>> .
>> .
>> .
>> “server_type”: “ppas”,
>> “version”: “ppas9.6”
>> }
>> }],
>> “schema_credentials”:
>> [{"func_acl": [],
>> "seq_acl": [],
>> .
>> .
>> .
>> .
>> “server_type”: “pg”,
>> “version”: “pg9.4”
>> }]
>> .
>> .
>> .
>> .
>> .
>> }
>>
>> Any suggestions?
>>
>> For multiple server currently we used 'owner' to identify the server, but
>> that fails if two servers have the same owner.
>>
>>
>> --
>> Thanks,
>> Navnath Gadakh
>> Software Engineer
>> EnterpriseDB Corporation
>> Mobile: +91 9975389878
>>
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Server specific advanced config file for testsuite
@ 2016-09-13 09:06 Navnath Gadakh <[email protected]>
parent: Dave Page <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Navnath Gadakh @ 2016-09-13 09:06 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Kanchan Mohitey <[email protected]>; pgadmin-hackers
Hi,
On Tue, Sep 13, 2016 at 2:18 PM, Dave Page <[email protected]>
wrote:
> BTW - I need the updated code that fixes all outstanding issues this
> week please. Release is coming up fast...
Yes. The enhanced test result is already completed, but before that drop
objects functionality is needed to complete. Which is already done for
servers & databases. So I will send a patch for these two nodes today &
after that for the remaining nodes(need some modifications
in existing setup & teardown for each test module)
We will try to finish this work end of this week.
Thanks.
>
> On Tue, Sep 13, 2016 at 9:48 AM, Dave Page <[email protected]>
> wrote:
> > Hi
> >
> > On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
> > <[email protected]> wrote:
> >> Hi Dave,
> >> As we know that, we are using two JSON files one is for basic
> >> configuration of server(test_config.json) and second for detailed
> >> configuration of server(test_advanced_config.json).
> >> In test_advanced_config.json, we give detail for database, schema,
> >> extension, collation etc. These details are generic I mean these
> details are
> >> not server specific.
> >> - Do we need to allow user to give server specific details?
> >
> > I don't see any reason to do so. Honestly I don't see much need for
> > test_advanced_config.json at all - I can't see anyone ever customising
> > the tests. I certainly doubt I will.
> >
> >> If yes, there should be some identification(like ‘server_type’,
> ‘version’)
> >> for each detail so that we can read server appropriate details.
> >> We have one approach in mind, to attach 'server_type' & 'version' to
> each
> >> detail
> >> So, modified test_advanced_config.json can be like this,
> >> {
> >> "add_database_data”:[
> >> {
> >> "conn_limit": -1,
> >> “owner”: “postres”,
> >> .
> >> .
> >> .
> >> .
> >> “server_type”: “pg”,
> >> “version”: “pg9.4”
> >> },
> >> {
> >> {
> >> "conn_limit": -1,
> >> “owner”: “enterprisedb”,
> >> .
> >> .
> >> .
> >> .
> >> “server_type”: “ppas”,
> >> “version”: “ppas9.6”
> >> }
> >> }],
> >> “schema_credentials”:
> >> [{"func_acl": [],
> >> "seq_acl": [],
> >> .
> >> .
> >> .
> >> .
> >> “server_type”: “pg”,
> >> “version”: “pg9.4”
> >> }]
> >> .
> >> .
> >> .
> >> .
> >> .
> >> }
> >>
> >> Any suggestions?
> >>
> >> For multiple server currently we used 'owner' to identify the server,
> but
> >> that fails if two servers have the same owner.
> >>
> >>
> >> --
> >> Thanks,
> >> Navnath Gadakh
> >> Software Engineer
> >> EnterpriseDB Corporation
> >> Mobile: +91 9975389878
> >>
> >>
> >
> >
> >
> > --
> > Dave Page
> > VP, Chief Architect, Tools & Installers
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > Blog: http://pgsnake.blogspot.com
> > Twitter: @pgsnake
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
--
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Server specific advanced config file for testsuite
@ 2016-09-13 09:12 Dave Page <[email protected]>
parent: Navnath Gadakh <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Dave Page @ 2016-09-13 09:12 UTC (permalink / raw)
To: Navnath Gadakh <[email protected]>; +Cc: Kanchan Mohitey <[email protected]>; pgadmin-hackers
On Tue, Sep 13, 2016 at 10:06 AM, Navnath Gadakh
<[email protected]> wrote:
> Hi,
>
> On Tue, Sep 13, 2016 at 2:18 PM, Dave Page <[email protected]>
> wrote:
>>
>> BTW - I need the updated code that fixes all outstanding issues this
>> week please. Release is coming up fast...
>
> Yes. The enhanced test result is already completed, but before that drop
> objects functionality is needed to complete. Which is already done for
> servers & databases. So I will send a patch for these two nodes today &
> after that for the remaining nodes(need some modifications in existing setup
> & teardown for each test module)
>
> We will try to finish this work end of this week.
https://goo.gl/FiPllO
:-)
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Server specific advanced config file for testsuite
@ 2016-09-13 12:09 Priyanka Shendge <[email protected]>
parent: Dave Page <[email protected]>
1 sibling, 1 reply; 7+ messages in thread
From: Priyanka Shendge @ 2016-09-13 12:09 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Navnath Gadakh <[email protected]>; Kanchan Mohitey <[email protected]>; pgadmin-hackers
On 13 September 2016 at 14:18, Dave Page <[email protected]> wrote:
> Hi
>
> On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
> <[email protected]> wrote:
> > Hi Dave,
> > As we know that, we are using two JSON files one is for basic
> > configuration of server(test_config.json) and second for detailed
> > configuration of server(test_advanced_config.json).
> > In test_advanced_config.json, we give detail for database, schema,
> > extension, collation etc. These details are generic I mean these details
> are
> > not server specific.
> > - Do we need to allow user to give server specific details?
>
> I don't see any reason to do so. Honestly I don't see much need for
> test_advanced_config.json at all - I can't see anyone ever customising
> the tests. I certainly doubt I will.
>
As per your suggestion, I have added test data to test_advanced_config.json
which will be used/changed by advanced user.
test_advanced_config.json contain test data for all nodes (i.e. database,
schema, tablespace etc..) except server.
If we dont use test_advanced_config.json file, from where we can fetch test
data for all nodes?
We wants to edit test_advanced_config.json as per server type and version
as there are 2 types of
servers available i.e. PostgreSQL and EPAS which might have different test
data as per server type.
e.g. "owner": in case of PG it can be owner: "postgres"
which may not be available for EPAS, for EPAS it can be "enterprisedb" or
vice versa.
If we do not modify the tests and run testsuite it will fail for multiple
servers.
> > If yes, there should be some identification(like ‘server_type’,
> ‘version’)
> > for each detail so that we can read server appropriate details.
> > We have one approach in mind, to attach 'server_type' & 'version' to each
> > detail
> > So, modified test_advanced_config.json can be like this,
> > {
> > "add_database_data”:[
> > {
> > "conn_limit": -1,
> > “owner”: “postres”,
> > .
> > .
> > .
> > .
> > “server_type”: “pg”,
> > “version”: “pg9.4”
> > },
> > {
> > {
> > "conn_limit": -1,
> > “owner”: “enterprisedb”,
> > .
> > .
> > .
> > .
> > “server_type”: “ppas”,
> > “version”: “ppas9.6”
> > }
> > }],
> > “schema_credentials”:
> > [{"func_acl": [],
> > "seq_acl": [],
> > .
> > .
> > .
> > .
> > “server_type”: “pg”,
> > “version”: “pg9.4”
> > }]
> > .
> > .
> > .
> > .
> > .
> > }
> >
> > Any suggestions?
> >
> > For multiple server currently we used 'owner' to identify the server, but
> > that fails if two servers have the same owner.
> >
> >
> > --
> > Thanks,
> > Navnath Gadakh
> > Software Engineer
> > EnterpriseDB Corporation
> > Mobile: +91 9975389878
> >
> >
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Best,
Priyanka
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Server specific advanced config file for testsuite
@ 2016-09-14 12:13 Dave Page <[email protected]>
parent: Priyanka Shendge <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Dave Page @ 2016-09-14 12:13 UTC (permalink / raw)
To: Priyanka Shendge <[email protected]>; +Cc: Navnath Gadakh <[email protected]>; Kanchan Mohitey <[email protected]>; pgadmin-hackers
Hi
On Tue, Sep 13, 2016 at 1:09 PM, Priyanka Shendge
<[email protected]> wrote:
>
>
> On 13 September 2016 at 14:18, Dave Page <[email protected]> wrote:
>>
>> Hi
>>
>> On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
>> <[email protected]> wrote:
>> > Hi Dave,
>> > As we know that, we are using two JSON files one is for basic
>> > configuration of server(test_config.json) and second for detailed
>> > configuration of server(test_advanced_config.json).
>> > In test_advanced_config.json, we give detail for database, schema,
>> > extension, collation etc. These details are generic I mean these details
>> > are
>> > not server specific.
>> > - Do we need to allow user to give server specific details?
>>
>> I don't see any reason to do so. Honestly I don't see much need for
>> test_advanced_config.json at all - I can't see anyone ever customising
>> the tests. I certainly doubt I will.
>
>
> As per your suggestion, I have added test data to test_advanced_config.json
> which will be used/changed by advanced user.
I suggested it because I didn't think it should all be in the main
config file. I didn't realise it was going to get so big at the time.
> test_advanced_config.json contain test data for all nodes (i.e. database,
> schema, tablespace etc..) except server.
> If we dont use test_advanced_config.json file, from where we can fetch test
> data for all nodes?
Hard-code it in the tests.
> We wants to edit test_advanced_config.json as per server type and version as
> there are 2 types of
> servers available i.e. PostgreSQL and EPAS which might have different test
> data as per server type.
> e.g. "owner": in case of PG it can be owner: "postgres"
> which may not be available for EPAS, for EPAS it can be "enterprisedb" or
> vice versa.
But that data is in the server config (test_config.json).
> If we do not modify the tests and run testsuite it will fail for multiple
> servers.
I honestly don't see why anything other than server-specific values
(i.e. connection info, tablespace path) needs to be customisable.
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2016-09-14 12:13 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 17:26 Server specific advanced config file for testsuite Navnath Gadakh <[email protected]>
2016-09-13 08:48 ` Dave Page <[email protected]>
2016-09-13 08:48 ` Dave Page <[email protected]>
2016-09-13 09:06 ` Navnath Gadakh <[email protected]>
2016-09-13 09:12 ` Dave Page <[email protected]>
2016-09-13 12:09 ` Priyanka Shendge <[email protected]>
2016-09-14 12:13 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox