public inbox for [email protected]help / color / mirror / Atom feed
RE-SQL test patch for extension node 7+ messages / 2 participants [nested] [flat]
* RE-SQL test patch for extension node @ 2019-07-05 14:14 Nagesh Dhope <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Nagesh Dhope @ 2019-07-05 14:14 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Please review attached patch for RE-SQL test cases for *extension* node. Thanks, Nagesh Dhope Attachments: [application/octet-stream] extension_resql_tests.patch (4.1K, 3-extension_resql_tests.patch) download | inline diff: diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_schema.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_schema.sql new file mode 100644 index 0000000..28fb182 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_schema.sql @@ -0,0 +1,7 @@ +-- Extension: timetravel + +-- DROP EXTENSION timetravel; + +CREATE EXTENSION timetravel + SCHEMA test_extension_schema + VERSION "1.0"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_version.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_version.sql new file mode 100644 index 0000000..6d193fb --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_version.sql @@ -0,0 +1,7 @@ +-- Extension: adminpack + +-- DROP EXTENSION adminpack; + +CREATE EXTENSION adminpack + SCHEMA pg_catalog + VERSION "1.1"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_all_options.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_all_options.sql new file mode 100644 index 0000000..0617532 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_all_options.sql @@ -0,0 +1,7 @@ +-- Extension: timetravel + +-- DROP EXTENSION timetravel; + +CREATE EXTENSION timetravel + SCHEMA public + VERSION "1.0"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_default_schema.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_default_schema.sql new file mode 100644 index 0000000..a9a61d4 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_default_schema.sql @@ -0,0 +1,7 @@ +-- Extension: adminpack + +-- DROP EXTENSION adminpack; + +CREATE EXTENSION adminpack + SCHEMA pg_catalog + VERSION "1.0"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/tests.json b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/tests.json new file mode 100644 index 0000000..fff75f8 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/tests.json @@ -0,0 +1,59 @@ +{ + "scenarios": [ + { + "type": "create", + "name": "Create Extension with all options", + "endpoint": "NODE-extension.obj", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "name": "timetravel", + "schema": "public", + "version": "1.0" + }, + "expected_sql_file": "create_extension_with_all_options.sql" + }, + { + "type": "alter", + "name": "Alter Extension version", + "endpoint": "NODE-extension.obj_id", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "schema": "test_extension_schema" + }, + "expected_sql_file": "alter_extension_schema.sql" + }, + { + "type": "delete", + "name": "Drop Extension with all options", + "endpoint": "NODE-extension.obj_id", + "data": {} + }, + { + "type": "create", + "name": "Create Extension with default(pg_catalog) schema", + "endpoint": "NODE-extension.obj", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "name": "adminpack", + "version": "1.0" + }, + "expected_sql_file": "create_extension_with_default_schema.sql" + }, + { + "type": "alter", + "name": "Alter Extension version", + "endpoint": "NODE-extension.obj_id", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "version": "1.1" + }, + "expected_sql_file": "alter_extension_version.sql" + }, + { + "type": "delete", + "name": "Drop Extension default(pg_catalog) schema", + "endpoint": "NODE-extension.obj_id", + "data": {} + } + ] +} ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: RE-SQL test patch for extension node @ 2019-07-08 08:33 Dave Page <[email protected]> parent: Nagesh Dhope <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Dave Page @ 2019-07-08 08:33 UTC (permalink / raw) To: Nagesh Dhope <[email protected]>; +Cc: pgadmin-hackers Hi On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope <[email protected]> wrote: > Hi Hackers, > Please review attached patch for RE-SQL test cases for *extension* node. > Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel contrib module has finally been removed. Perhaps use sslinfo? That seems less likely to go away anytime soon. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: RE-SQL test patch for extension node @ 2019-07-09 05:16 Nagesh Dhope <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Nagesh Dhope @ 2019-07-09 05:16 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Hi Dave, Please find updated patch with *sslinfo.* On Mon, Jul 8, 2019 at 2:03 PM Dave Page <[email protected]> wrote: > Hi > > On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope <[email protected]> > wrote: > >> Hi Hackers, >> Please review attached patch for RE-SQL test cases for *extension* node. >> > > Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel > contrib module has finally been removed. > > Perhaps use sslinfo? That seems less likely to go away anytime soon. > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > Attachments: [application/octet-stream] extension_resql_tests_v2.patch (4.1K, 3-extension_resql_tests_v2.patch) download | inline diff: diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_schema.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_schema.sql new file mode 100644 index 0000000..fc8fc10 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_schema.sql @@ -0,0 +1,7 @@ +-- Extension: sslinfo + +-- DROP EXTENSION sslinfo; + +CREATE EXTENSION sslinfo + SCHEMA test_extension_schema + VERSION "1.2"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_version.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_version.sql new file mode 100644 index 0000000..6d193fb --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_version.sql @@ -0,0 +1,7 @@ +-- Extension: adminpack + +-- DROP EXTENSION adminpack; + +CREATE EXTENSION adminpack + SCHEMA pg_catalog + VERSION "1.1"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_all_options.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_all_options.sql new file mode 100644 index 0000000..37c620c --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_all_options.sql @@ -0,0 +1,7 @@ +-- Extension: sslinfo + +-- DROP EXTENSION sslinfo; + +CREATE EXTENSION sslinfo + SCHEMA public + VERSION "1.2"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_default_schema.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_default_schema.sql new file mode 100644 index 0000000..a9a61d4 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_default_schema.sql @@ -0,0 +1,7 @@ +-- Extension: adminpack + +-- DROP EXTENSION adminpack; + +CREATE EXTENSION adminpack + SCHEMA pg_catalog + VERSION "1.0"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/tests.json b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/tests.json new file mode 100644 index 0000000..a450120 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/tests.json @@ -0,0 +1,59 @@ +{ + "scenarios": [ + { + "type": "create", + "name": "Create Extension with all options", + "endpoint": "NODE-extension.obj", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "name": "sslinfo", + "schema": "public", + "version": "1.2" + }, + "expected_sql_file": "create_extension_with_all_options.sql" + }, + { + "type": "alter", + "name": "Alter Extension version", + "endpoint": "NODE-extension.obj_id", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "schema": "test_extension_schema" + }, + "expected_sql_file": "alter_extension_schema.sql" + }, + { + "type": "delete", + "name": "Drop Extension with all options", + "endpoint": "NODE-extension.obj_id", + "data": {} + }, + { + "type": "create", + "name": "Create Extension with default(pg_catalog) schema", + "endpoint": "NODE-extension.obj", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "name": "adminpack", + "version": "1.0" + }, + "expected_sql_file": "create_extension_with_default_schema.sql" + }, + { + "type": "alter", + "name": "Alter Extension version", + "endpoint": "NODE-extension.obj_id", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "version": "1.1" + }, + "expected_sql_file": "alter_extension_version.sql" + }, + { + "type": "delete", + "name": "Drop Extension default(pg_catalog) schema", + "endpoint": "NODE-extension.obj_id", + "data": {} + } + ] +} ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: RE-SQL test patch for extension node @ 2019-07-09 11:24 Dave Page <[email protected]> parent: Nagesh Dhope <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Dave Page @ 2019-07-09 11:24 UTC (permalink / raw) To: Nagesh Dhope <[email protected]>; +Cc: pgadmin-hackers Hi I have a sneaking suspicion that the work Akshay and Khushboo have been doing might have broken this :-( Create Extension with all options..............OK ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): Error Message:ERROR: schema "test_extension_schema" does not exist Alter Extension version..............FAIL Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line 230, in execute_test_case self.assertEquals(response.status_code, 200) File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 1338, in deprecated_func return original_func(*args, **kwargs) File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 839, in assertEqual assertion_func(first, second, msg=msg) File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", line 832, in _baseAssertEqual raise self.failureException(msg) AssertionError: 500 != 200 On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope <[email protected]> wrote: > Hi Dave, > > Please find updated patch with *sslinfo.* > > On Mon, Jul 8, 2019 at 2:03 PM Dave Page <[email protected]> wrote: > >> Hi >> >> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < >> [email protected]> wrote: >> >>> Hi Hackers, >>> Please review attached patch for RE-SQL test cases for *extension* >>> node. >>> >> >> Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel >> contrib module has finally been removed. >> >> Perhaps use sslinfo? That seems less likely to go away anytime soon. >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: RE-SQL test patch for extension node @ 2019-07-09 12:09 Nagesh Dhope <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Nagesh Dhope @ 2019-07-09 12:09 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Hi Dave, On Tue, Jul 9, 2019 at 4:54 PM Dave Page <[email protected]> wrote: > Hi > > I have a sneaking suspicion that the work Akshay and Khushboo have been > doing might have broken this :-( > Yup, earlier we were able to create a schema if not exists while running *alter *test cases. As this capability is remove alter test case for extension was failing. I have fixed the test case, PFA updated patch. > Create Extension with all options..............OK > ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query > (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): > Error Message:ERROR: schema "test_extension_schema" does not exist > > Alter Extension version..............FAIL > Traceback (most recent call last): > File > "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line > 230, in execute_test_case > self.assertEquals(response.status_code, 200) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 1338, in deprecated_func > return original_func(*args, **kwargs) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 839, in assertEqual > assertion_func(first, second, msg=msg) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 832, in _baseAssertEqual > raise self.failureException(msg) > AssertionError: 500 != 200 > > > On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope <[email protected]> > wrote: > >> Hi Dave, >> >> Please find updated patch with *sslinfo.* >> >> On Mon, Jul 8, 2019 at 2:03 PM Dave Page <[email protected]> wrote: >> >>> Hi >>> >>> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < >>> [email protected]> wrote: >>> >>>> Hi Hackers, >>>> Please review attached patch for RE-SQL test cases for *extension* >>>> node. >>>> >>> >>> Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel >>> contrib module has finally been removed. >>> >>> Perhaps use sslinfo? That seems less likely to go away anytime soon. >>> >>> Thanks. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > Attachments: [application/octet-stream] extension_resql_tests_v3.patch (4.1K, 3-extension_resql_tests_v3.patch) download | inline diff: diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_schema.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_schema.sql new file mode 100644 index 0000000..37c620c --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_schema.sql @@ -0,0 +1,7 @@ +-- Extension: sslinfo + +-- DROP EXTENSION sslinfo; + +CREATE EXTENSION sslinfo + SCHEMA public + VERSION "1.2"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_version.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_version.sql new file mode 100644 index 0000000..6d193fb --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/alter_extension_version.sql @@ -0,0 +1,7 @@ +-- Extension: adminpack + +-- DROP EXTENSION adminpack; + +CREATE EXTENSION adminpack + SCHEMA pg_catalog + VERSION "1.1"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_all_options.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_all_options.sql new file mode 100644 index 0000000..fc8fc10 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_all_options.sql @@ -0,0 +1,7 @@ +-- Extension: sslinfo + +-- DROP EXTENSION sslinfo; + +CREATE EXTENSION sslinfo + SCHEMA test_extension_schema + VERSION "1.2"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_default_schema.sql b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_default_schema.sql new file mode 100644 index 0000000..a9a61d4 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/create_extension_with_default_schema.sql @@ -0,0 +1,7 @@ +-- Extension: adminpack + +-- DROP EXTENSION adminpack; + +CREATE EXTENSION adminpack + SCHEMA pg_catalog + VERSION "1.0"; diff --git a/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/tests.json b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/tests.json new file mode 100644 index 0000000..c289349 --- /dev/null +++ b/web/pgadmin/browser/server_groups/servers/databases/extensions/tests/default/tests.json @@ -0,0 +1,59 @@ +{ + "scenarios": [ + { + "type": "create", + "name": "Create Extension with all options", + "endpoint": "NODE-extension.obj", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "name": "sslinfo", + "schema": "test_extension_schema", + "version": "1.2" + }, + "expected_sql_file": "create_extension_with_all_options.sql" + }, + { + "type": "alter", + "name": "Alter Extension version", + "endpoint": "NODE-extension.obj_id", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "schema": "public" + }, + "expected_sql_file": "alter_extension_schema.sql" + }, + { + "type": "delete", + "name": "Drop Extension with all options", + "endpoint": "NODE-extension.obj_id", + "data": {} + }, + { + "type": "create", + "name": "Create Extension with default(pg_catalog) schema", + "endpoint": "NODE-extension.obj", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "name": "adminpack", + "version": "1.0" + }, + "expected_sql_file": "create_extension_with_default_schema.sql" + }, + { + "type": "alter", + "name": "Alter Extension version", + "endpoint": "NODE-extension.obj_id", + "sql_endpoint": "NODE-extension.sql_id", + "data": { + "version": "1.1" + }, + "expected_sql_file": "alter_extension_version.sql" + }, + { + "type": "delete", + "name": "Drop Extension default(pg_catalog) schema", + "endpoint": "NODE-extension.obj_id", + "data": {} + } + ] +} ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: RE-SQL test patch for extension node @ 2019-07-09 12:23 Dave Page <[email protected]> parent: Nagesh Dhope <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Dave Page @ 2019-07-09 12:23 UTC (permalink / raw) To: Nagesh Dhope <[email protected]>; +Cc: pgadmin-hackers Thanks, applied! On Tue, Jul 9, 2019 at 1:09 PM Nagesh Dhope <[email protected]> wrote: > Hi Dave, > > On Tue, Jul 9, 2019 at 4:54 PM Dave Page <[email protected]> wrote: > >> Hi >> >> I have a sneaking suspicion that the work Akshay and Khushboo have been >> doing might have broken this :-( >> > > Yup, earlier we were able to create a schema if not exists while running *alter > *test cases. As this capability is remove alter test case for extension > was failing. > I have fixed the test case, PFA updated patch. > > >> Create Extension with all options..............OK >> ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query >> (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): >> Error Message:ERROR: schema "test_extension_schema" does not exist >> >> Alter Extension version..............FAIL >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line >> 230, in execute_test_case >> self.assertEquals(response.status_code, 200) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 1338, in deprecated_func >> return original_func(*args, **kwargs) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 839, in assertEqual >> assertion_func(first, second, msg=msg) >> File >> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >> line 832, in _baseAssertEqual >> raise self.failureException(msg) >> AssertionError: 500 != 200 >> >> >> On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope < >> [email protected]> wrote: >> >>> Hi Dave, >>> >>> Please find updated patch with *sslinfo.* >>> >>> On Mon, Jul 8, 2019 at 2:03 PM Dave Page <[email protected]> wrote: >>> >>>> Hi >>>> >>>> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < >>>> [email protected]> wrote: >>>> >>>>> Hi Hackers, >>>>> Please review attached patch for RE-SQL test cases for *extension* >>>>> node. >>>>> >>>> >>>> Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel >>>> contrib module has finally been removed. >>>> >>>> Perhaps use sslinfo? That seems less likely to go away anytime soon. >>>> >>>> Thanks. >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: RE-SQL test patch for extension node @ 2019-07-11 06:24 Nagesh Dhope <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 0 replies; 7+ messages in thread From: Nagesh Dhope @ 2019-07-11 06:24 UTC (permalink / raw) To: pgadmin-hackers Please ignore this patch. Sending updated on new thread On Thu, Jul 11, 2019 at 11:40 AM Nagesh Dhope <[email protected]> wrote: > Fixed failing extension resql test cases on PG 9.4 and PG 9.5. > PFA updated patch. > > On Tue, Jul 9, 2019 at 5:53 PM Dave Page <[email protected]> wrote: > >> Thanks, applied! >> >> On Tue, Jul 9, 2019 at 1:09 PM Nagesh Dhope < >> [email protected]> wrote: >> >>> Hi Dave, >>> >>> On Tue, Jul 9, 2019 at 4:54 PM Dave Page <[email protected]> wrote: >>> >>>> Hi >>>> >>>> I have a sneaking suspicion that the work Akshay and Khushboo have been >>>> doing might have broken this :-( >>>> >>> >>> Yup, earlier we were able to create a schema if not exists while >>> running *alter *test cases. As this capability is remove alter test >>> case for extension was failing. >>> I have fixed the test case, PFA updated patch. >>> >>> >>>> Create Extension with all options..............OK >>>> ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query >>>> (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): >>>> Error Message:ERROR: schema "test_extension_schema" does not exist >>>> >>>> Alter Extension version..............FAIL >>>> Traceback (most recent call last): >>>> File >>>> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line >>>> 230, in execute_test_case >>>> self.assertEquals(response.status_code, 200) >>>> File >>>> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >>>> line 1338, in deprecated_func >>>> return original_func(*args, **kwargs) >>>> File >>>> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >>>> line 839, in assertEqual >>>> assertion_func(first, second, msg=msg) >>>> File >>>> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >>>> line 832, in _baseAssertEqual >>>> raise self.failureException(msg) >>>> AssertionError: 500 != 200 >>>> >>>> >>>> On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope < >>>> [email protected]> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Please find updated patch with *sslinfo.* >>>>> >>>>> On Mon, Jul 8, 2019 at 2:03 PM Dave Page <[email protected]> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> Please review attached patch for RE-SQL test cases for *extension* >>>>>>> node. >>>>>>> >>>>>> >>>>>> Unfortunately this fails on PostgreSQL 12 as the deprecated >>>>>> timetravel contrib module has finally been removed. >>>>>> >>>>>> Perhaps use sslinfo? That seems less likely to go away anytime soon. >>>>>> >>>>>> Thanks. >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2019-07-11 06:24 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-07-05 14:14 RE-SQL test patch for extension node Nagesh Dhope <[email protected]> 2019-07-08 08:33 ` Dave Page <[email protected]> 2019-07-09 05:16 ` Nagesh Dhope <[email protected]> 2019-07-09 11:24 ` Dave Page <[email protected]> 2019-07-09 12:09 ` Nagesh Dhope <[email protected]> 2019-07-09 12:23 ` Dave Page <[email protected]> 2019-07-11 06:24 ` Nagesh Dhope <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox