public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4[RM#3948] Fix backform note control style
6+ messages / 4 participants
[nested] [flat]
* [pgAdmin4[RM#3948] Fix backform note control style
@ 2019-01-30 10:22 Murtuza Zabuawala <[email protected]>
2019-01-30 11:09 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Khushboo Vashi <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Murtuza Zabuawala @ 2019-01-30 10:22 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA minor patch to fix the style, changed the background colour and text
colour so that it can be readable.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[application/octet-stream] RM_3948.diff (1.2K, 3-RM_3948.diff)
download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index d313541b..6e8a3bdb 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -2348,7 +2348,7 @@ define([
},
template: _.template([
'<div class="<%=noteClass%> pg-el-12 <%=extraClasses.join(\' \')%>">',
- '<label class="control-label"><%=label%>:</label>',
+ '<strong><%=label%>:</strong> ',
'<span><%=text%></span></div>',
].join('\n')),
});
diff --git a/web/pgadmin/static/scss/_backform.overrides.scss b/web/pgadmin/static/scss/_backform.overrides.scss
index 0a413e37..668e6eab 100644
--- a/web/pgadmin/static/scss/_backform.overrides.scss
+++ b/web/pgadmin/static/scss/_backform.overrides.scss
@@ -50,11 +50,11 @@
.backform_control_notes {
border: $panel-border;
border-radius: $border-radius;
- font-family: $font-family-editor;
- font-size: 0.8rem;
+ font-size: 0.850rem;
margin: 0 0 10px;
- padding: 5px 10px;
word-wrap: break-word;
+ color: $color-gray-dark;
+ background: $color-gray-lighter;
}
div.backform_control_notes label.control-label {
min-width: 0px;
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgAdmin4[RM#3948] Fix backform note control style
2019-01-30 10:22 [pgAdmin4[RM#3948] Fix backform note control style Murtuza Zabuawala <[email protected]>
@ 2019-01-30 11:09 ` Khushboo Vashi <[email protected]>
2019-02-01 13:12 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Chethana Kumar <[email protected]>
2019-02-08 12:56 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Murtuza Zabuawala <[email protected]>
0 siblings, 2 replies; 6+ messages in thread
From: Khushboo Vashi @ 2019-01-30 11:09 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; Chethana Kumar <[email protected]>; +Cc: pgadmin-hackers
Hi Murtuza,
I have reviewed your patch and I feel we need Chethana's suggestion on this.
@ Chethana,
Please have a look the attached screen-shots (Existing_design and
Proposed_design). With this patch the *Note* section design has been
changed.
We need your suggestion on this to improve it as I feel it needs
improvement.
Thanks,
Khushboo
On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA minor patch to fix the style, changed the background colour and text
> colour so that it can be readable.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
Attachments:
[image/png] Existing_design.png (630.2K, 3-Existing_design.png)
download | view image
[image/png] Proposed_design.png (633.1K, 4-Proposed_design.png)
download | view image
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgAdmin4[RM#3948] Fix backform note control style
2019-01-30 10:22 [pgAdmin4[RM#3948] Fix backform note control style Murtuza Zabuawala <[email protected]>
2019-01-30 11:09 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Khushboo Vashi <[email protected]>
@ 2019-02-01 13:12 ` Chethana Kumar <[email protected]>
2019-02-01 13:15 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Ashesh Vashi <[email protected]>
1 sibling, 1 reply; 6+ messages in thread
From: Chethana Kumar @ 2019-02-01 13:12 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Hi Khushboo and Murtuza,
I have attached the improved version of the design, please share your views.
A '*note*' text should be always be highlighted rather than keeping it
muted (faded coloured text).
---
Chethana kumar
[image: Existing_design.png]
On Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <
[email protected]> wrote:
> Hi Murtuza,
>
> I have reviewed your patch and I feel we need Chethana's suggestion on
> this.
>
> @ Chethana,
>
> Please have a look the attached screen-shots (Existing_design and
> Proposed_design). With this patch the *Note* section design has been
> changed.
> We need your suggestion on this to improve it as I feel it needs
> improvement.
>
> Thanks,
> Khushboo
>
>
> On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the style, changed the background colour and text
>> colour so that it can be readable.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
The Postgres Database Company
P: +91 86981 57146
www.enterprisedb.com
Attachments:
[image/png] Existing_design.png (392.8K, 3-Existing_design.png)
download | view image
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgAdmin4[RM#3948] Fix backform note control style
2019-01-30 10:22 [pgAdmin4[RM#3948] Fix backform note control style Murtuza Zabuawala <[email protected]>
2019-01-30 11:09 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Khushboo Vashi <[email protected]>
2019-02-01 13:12 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Chethana Kumar <[email protected]>
@ 2019-02-01 13:15 ` Ashesh Vashi <[email protected]>
2019-02-01 13:23 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Chethana Kumar <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Ashesh Vashi @ 2019-02-01 13:15 UTC (permalink / raw)
To: Chethana Kumar <[email protected]>; +Cc: Khushboo Vashi <[email protected]>; Murtuza Zabuawala <[email protected]>; pgadmin-hackers
On Fri, Feb 1, 2019 at 6:42 PM Chethana Kumar <
[email protected]> wrote:
> Hi Khushboo and Murtuza,
>
> I have attached the improved version of the design, please share your
> views.
> A '*note*' text should be always be highlighted rather than keeping it
> muted (faded coloured text).
>
Chethana,
Can you please send the color combination, when the note control is
appeared under a subnode control (with white background color)?
-- Thanks, Ashesh
>
> ---
> Chethana kumar
> [image: Existing_design.png]
>
>
>
> On Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi Murtuza,
>>
>> I have reviewed your patch and I feel we need Chethana's suggestion on
>> this.
>>
>> @ Chethana,
>>
>> Please have a look the attached screen-shots (Existing_design and
>> Proposed_design). With this patch the *Note* section design has been
>> changed.
>> We need your suggestion on this to improve it as I feel it needs
>> improvement.
>>
>> Thanks,
>> Khushboo
>>
>>
>> On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to fix the style, changed the background colour and text
>>> colour so that it can be readable.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>
> --
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
>
> The Postgres Database Company
>
> P: +91 86981 57146
> www.enterprisedb.com
>
Attachments:
[image/png] Existing_design.png (392.8K, 3-Existing_design.png)
download | view image
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgAdmin4[RM#3948] Fix backform note control style
2019-01-30 10:22 [pgAdmin4[RM#3948] Fix backform note control style Murtuza Zabuawala <[email protected]>
2019-01-30 11:09 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Khushboo Vashi <[email protected]>
2019-02-01 13:12 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Chethana Kumar <[email protected]>
2019-02-01 13:15 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Ashesh Vashi <[email protected]>
@ 2019-02-01 13:23 ` Chethana Kumar <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Chethana Kumar @ 2019-02-01 13:23 UTC (permalink / raw)
To: Ashesh Vashi <[email protected]>; +Cc: Khushboo Vashi <[email protected]>; Murtuza Zabuawala <[email protected]>; pgadmin-hackers
Ashesh,
It remains same with the white background because the note icon itself
enough to grab the attention of the user.
I have attached the design sample as well.
[image: with-patch.png]
---
Chethana kumar
On Fri, Feb 1, 2019 at 6:45 PM Ashesh Vashi <[email protected]>
wrote:
> On Fri, Feb 1, 2019 at 6:42 PM Chethana Kumar <
> [email protected]> wrote:
>
>> Hi Khushboo and Murtuza,
>>
>> I have attached the improved version of the design, please share your
>> views.
>> A '*note*' text should be always be highlighted rather than keeping it
>> muted (faded coloured text).
>>
> Chethana,
>
> Can you please send the color combination, when the note control is
> appeared under a subnode control (with white background color)?
>
> -- Thanks, Ashesh
>
>>
>> ---
>> Chethana kumar
>> [image: Existing_design.png]
>>
>>
>>
>> On Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi Murtuza,
>>>
>>> I have reviewed your patch and I feel we need Chethana's suggestion on
>>> this.
>>>
>>> @ Chethana,
>>>
>>> Please have a look the attached screen-shots (Existing_design and
>>> Proposed_design). With this patch the *Note* section design has been
>>> changed.
>>> We need your suggestion on this to improve it as I feel it needs
>>> improvement.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>
>>> On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA minor patch to fix the style, changed the background colour and
>>>> text colour so that it can be readable.
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>
>> --
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146
>> www.enterprisedb.com
>>
>
--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
The Postgres Database Company
P: +91 86981 57146
www.enterprisedb.com
Attachments:
[image/png] Existing_design.png (392.8K, 3-Existing_design.png)
download | view image
[image/png] with-patch.png (292.1K, 4-with-patch.png)
download | view image
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgAdmin4[RM#3948] Fix backform note control style
2019-01-30 10:22 [pgAdmin4[RM#3948] Fix backform note control style Murtuza Zabuawala <[email protected]>
2019-01-30 11:09 ` Re: [pgAdmin4[RM#3948] Fix backform note control style Khushboo Vashi <[email protected]>
@ 2019-02-08 12:56 ` Murtuza Zabuawala <[email protected]>
1 sibling, 0 replies; 6+ messages in thread
From: Murtuza Zabuawala @ 2019-02-08 12:56 UTC (permalink / raw)
To: pgadmin-hackers; Khushboo Vashi <[email protected]>
Hi,
PFA updated patch.
Regards,
Murtuza
>
>> On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to fix the style, changed the background colour and text
>>> colour so that it can be readable.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
Attachments:
[application/octet-stream] RM_3948_v1.diff (2.2K, 3-RM_3948_v1.diff)
download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index d180bcbd..c2065a67 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -2380,13 +2380,22 @@ define([
defaults: {
label: gettext('Note'),
text: '',
- extraClasses: [],
+ extraClasses: ['pg-el-12', 'd-flex'],
noteClass: 'backform_control_notes',
+ faIcon: 'fa-file-text-o',
+ faExtraClass: 'fa-rotate-180 fa-flip-vertical',
+ iconWidthClass: 'col-0 pr-2',
+ textWidthClass: 'col-12',
},
template: _.template([
- '<div class="<%=noteClass%> pg-el-12 <%=extraClasses.join(\' \')%>">',
- '<label class="control-label"><%=label%>:</label>',
- '<span><%=text%></span></div>',
+ '<div class="<%=noteClass%> <%=extraClasses.join(\' \')%>">',
+ ' <div class="<%=iconWidthClass%>">',
+ ' <i class="fa <%=faIcon%> <%=faExtraClass%>" aria-hidden="true"></i>',
+ ' </div>',
+ ' <div class="<%=textWidthClass%>">',
+ ' <span><%=text%></span>',
+ ' </div>',
+ '</div>',
].join('\n')),
});
diff --git a/web/pgadmin/static/scss/_backform.overrides.scss b/web/pgadmin/static/scss/_backform.overrides.scss
index 0a413e37..4d4fe376 100644
--- a/web/pgadmin/static/scss/_backform.overrides.scss
+++ b/web/pgadmin/static/scss/_backform.overrides.scss
@@ -50,14 +50,10 @@
.backform_control_notes {
border: $panel-border;
border-radius: $border-radius;
- font-family: $font-family-editor;
- font-size: 0.8rem;
margin: 0 0 10px;
- padding: 5px 10px;
- word-wrap: break-word;
-}
-div.backform_control_notes label.control-label {
- min-width: 0px;
+ padding: 5px 10px;
+ word-wrap: break-word;
+ background: $yellow;
}
.subnode-header label {
diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss
index b25610bd..fc163a6b 100644
--- a/web/pgadmin/static/scss/resources/_default.variables.scss
+++ b/web/pgadmin/static/scss/resources/_default.variables.scss
@@ -3,6 +3,7 @@ $enable-flex: true !default;
$white: #fff;
$black: #000;
+$yellow: #fff9c4;
$color-bg: $white !default;
$color-fg: #222222 !default;
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2019-02-08 12:56 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 10:22 [pgAdmin4[RM#3948] Fix backform note control style Murtuza Zabuawala <[email protected]>
2019-01-30 11:09 ` Khushboo Vashi <[email protected]>
2019-02-01 13:12 ` Chethana Kumar <[email protected]>
2019-02-01 13:15 ` Ashesh Vashi <[email protected]>
2019-02-01 13:23 ` Chethana Kumar <[email protected]>
2019-02-08 12:56 ` Murtuza Zabuawala <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox