public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin] RM6084 Uncaught TypeError exception displayed on schema diff identical option
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin] RM6084 Uncaught TypeError exception displayed on schema diff identical option
@ 2020-12-17 13:37 Rahul Shirsat <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Shirsat @ 2020-12-17 13:37 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find the attached patch which resolves 2 issues:
1. When the user applies the "Identical" filter before hitting the
Compare button. (All Browsers)
2. When comparing data is loaded, and when the user selects identical
table comparison, infinite loader "Comparing objects..." shows up in
Firefox.
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM6084.patch (1.1K, 3-RM6084.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js b/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
index 1f499e5cd..6738a64b4 100644
--- a/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
+++ b/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
@@ -456,7 +456,9 @@ export default class SchemaDiffUI {
grid.onSelectedRowsChanged.subscribe(self.handleDependencies.bind(this));
- self.model.on('change:diff_ddl', self.handleDependencies.bind(self));
+ self.model.on('change:diff_ddl', function(event) {
+ self.handleDependencies.bind(event, self);
+ });
$('#schema-diff-grid').on('keyup', function() {
if ((event.keyCode == 38 || event.keyCode ==40) && this.grid.getActiveCell().row) {
@@ -831,8 +833,12 @@ export default class SchemaDiffUI {
}
}
});
- // Refresh the grid
- self.dataView.refresh();
+
+ // Check whether comparison data is loaded or not
+ if(!_.isUndefined(self.dataView) && !_.isNull(self.dataView)) {
+ // Refresh the grid
+ self.dataView.refresh();
+ }
}
connect_database(server_id, db_id, callback) {
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin] RM6084 Uncaught TypeError exception displayed on schema diff identical option
@ 2020-12-21 09:40 Akshay Joshi <[email protected]>
parent: Rahul Shirsat <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2020-12-21 09:40 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Thu, Dec 17, 2020 at 7:08 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached patch which resolves 2 issues:
>
> 1. When the user applies the "Identical" filter before hitting the
> Compare button. (All Browsers)
> 2. When comparing data is loaded, and when the user selects identical
> table comparison, infinite loader "Comparing objects..." shows up in
> Firefox.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2020-12-21 09:40 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17 13:37 [pgAdmin] RM6084 Uncaught TypeError exception displayed on schema diff identical option Rahul Shirsat <[email protected]>
2020-12-21 09:40 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox