pg.ddx.io GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)
help / color / mirror / Atom feed[pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
25+ messages / 4 participants
[nested] [flat]
* [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-10-29 16:02 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
0 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-10-29 16:02 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Before, a password in a JDBC URL could reach the log or an exception message: the driver
logged the full URL at FINE on every connection and at WARNING for some malformed URLs, and
put it in the exception for a URL it could not parse. A `user:password@` part, which libpq
accepts, was read as a part of the host, the port, or the database name and logged too.
The driver now masks `password` and `sslpassword` in every URL it logs or puts in an exception
message, refuses `user:password@` before the host using libpq's rule, and does not log other
parts of a URL that may hold a password. See the commit messages for details.
Behavior change: URLs with `user:password@` before the host, or with `@` or `/` in a parameter
name, are refused. Both were broken already, and the docs require such characters to be
percent-encoded. `user=name@server` and an `@` in a database name are accepted as before.
Known limitations:
- As in libpq, a password with a raw `/`, as in `user:1234/word@host`, is read as a port and a
database name.
This is extraction from https://github.com/pgjdbc/pgjdbc/pull/4251
### All Submissions:
* [x] Have you followed the guidelines in our [Contributing](https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md) document?
* [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?
<!-- You can erase any parts of this template not applicable to your Pull Request. -->
### New Feature Submissions:
1. [x] Does your submission pass tests?
2. [x] Does `./gradlew styleCheck` pass ?
3. [ ] Have you added your new test classes to an existing test suite in alphabetical order?
### Changes to Existing Features:
* [x] Does this break existing behaviour? If so please explain.
* [x] Have you added an explanation of what your changes do and why you'd like us to include them?
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-10-29 16:03 "gitguardian[bot] (bot) (@gitguardian[bot])" <noreply+gitguardian[bot]@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: gitguardian[bot] (bot) (@gitguardian[bot]) @ 2026-10-29 16:03 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
#### ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
<details>
<summary>🔎 Detected hardcoded secret in your pull request</summary>
<br>
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
| -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | Generic Password | 3a594415481a4cb86292aa0f5caf9be2e40c6837 | pgjdbc/src/test/java/org/postgresql/util/internal/JdbcUrlMaskerTest.java | [View secret](https://github.com/pgjdbc/pgjdbc/commit/3a594415481a4cb86292aa0f5caf9be2e40c6837#diff-bda439cd4223b2...) |
</details>
<details>
<summary>🛠 Guidelines to remediate hardcoded secrets</summary>
<br>
1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_che...) the best practices.
3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_p...).
4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=...). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_ch...) for managing and storing secrets including API keys and other credentials
- install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&...) to catch secret before it leaves your machine and ease remediation.
</details>
---
<sup>🦉 [GitGuardian](https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&utm_source=github&...) detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.<br/></sup>
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-10-29 17:04 "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: codecov[bot] (bot) (@codecov[bot]) @ 2026-10-29 17:04 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
## [Codecov](https://app.codecov.io/gh/pgjdbc/pgjdbc/pull/4512?dropdown=coverage&src=pr&el=h1&utm_med...) Report
:x: Patch coverage is `84.31373%` with `8 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 72.44%. Comparing base ([`a3fad9d`](https://app.codecov.io/gh/pgjdbc/pgjdbc/commit/a3fad9d6bd7e3372be0c97035d13363db671355f?dropdown=cov...)) to head ([`d596d08`](https://app.codecov.io/gh/pgjdbc/pgjdbc/commit/d596d0878fe368a148b41497fed22d27da3f6d8e?dropdown=cov...)).
:warning: Report is 28 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4512 +/- ##
============================================
+ Coverage 72.37% 72.44% +0.06%
- Complexity 5485 5495 +10
============================================
Files 244 244
Lines 22193 22225 +32
Branches 3730 3735 +5
============================================
+ Hits 16063 16100 +37
+ Misses 4464 4459 -5
Partials 1666 1666
```
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGPropertyTest.java)
**nit**: test placement and shape
- The tests exercise `Driver.parseURL`, `Driver.connect`, and `BaseDataSource`, not `PGProperty`; `DriverTest` already tests `parseURL` and bad URLs (`badUrlsTest`, `rejectsBadUrls`).
- `masksUnusualQueryString` checks four cases in one method, and the first failure hides the rest; a `@ParameterizedTest` with named rows reports each one.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512 (changes requested): fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Severity: please fix major and minor before merge. nit is up to you; if you skip one, a short reply saying why is enough.
[follow-up] `pgjdbc/src/main/java/org/postgresql/jdbcurlresolver/PgServiceConfParser.java:239` logs an invalid line of `pg_service.conf` whole: a line whose key is not recognized at `SEVERE` (line 239), and a line without `=` at `WARNING` (line 252). `password = s3cret` takes that path: the space before `=` makes the key `password `, so the password reaches the log. It is outside this PR's diff; a follow-up issue would keep it from being lost.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/Driver.java)
**major**: another driver's URL is still logged with its credentials
`acceptsURL` (and `getPropertyInfo`) pass any URL to `parseURL`, and `DriverManager.getDriver(url)` calls `acceptsURL` on every registered driver, so this record is written for URLs meant for other drivers. `maskSensitiveValues` only knows the `?name=value&...` syntax, so `jdbc:sqlserver://h;user=u;password=p` and `jdbc:oracle:thin:u/p@h:1521/x` reach the `FINE` log unchanged. Please drop the URL from this record, for example `JDBC URL does not start with "jdbc:postgresql:"`, and add a test: no test covers this record now.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/util/PGPropertyUtil.java)
**major**: `maskSensitiveValues` becomes public API
`org.postgresql.util.PGPropertyUtil` is public, so this method falls under the backward-compatibility promise, while its only callers are `Driver` and `BaseDataSource`. Please move it to `org.postgresql.util.internal`.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/PGProperty.java:1036)
**minor**: the Javadoc of `isSensitive()` does not say what "sensitive" means
It is new public API, and the summary and `@return` repeat each other. Please state the contract, for example:
```java
/**
* Returns whether the value of this parameter is a secret, such as a password or the passphrase of a key.
* The driver replaces the value of such a parameter with {@code ***} where it logs a JDBC URL or puts one
* in an exception message.
*
* @return {@code true} if the value of this parameter must not be disclosed
*/
```
The same applies to `These parameters should not be disclosed.` on `SENSITIVE_PROPERTIES`, and to `maskSensitiveValues`, whose Javadoc does not say that only the query string after the first `?` is changed and that parameter names match exactly.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on CHANGELOG.md)
**minor**: the entry has no link and claims more than the code does
Every other entry ends with a link to its PR, issue, or advisory; please add `[PR #4512](https://github.com/pgjdbc/pgjdbc/pull/4512)`. "wherever the driver logs the URL" is not true while another driver's URL and the user-info form still leak; if those stay out of scope, say that only the `password` and `sslpassword` query parameters are masked.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/test/java/org/postgresql/util/PGPropertyUtilTest.java)
**nit**: an empty password is shown as `***`
`password=` (empty) disables the `.pgpass` lookup (`Driver.parseURL` reads `.pgpass` only when the password is `null`), and the log then shows `password=***`, which tells someone debugging an authentication failure that a password was set. An empty value discloses nothing; please leave it as `password=`.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/util/PGPropertyUtil.java)
**major**: a password in the user-info part reaches a WARNING and the exception
libpq accepts `postgresql://alice:s3cret@db/app`, so users paste that form into a JDBC URL. `parseURL` splits the address at the last `:`, so the port becomes `s3cret@db`, and `propertiesConsistencyCheck` logs `JDBC URL invalid port number: s3cret@db` at `WARNING` (`PGPropertyUtil.java:78`), which the default JUL configuration prints. `Driver.connect` then throws `Unable to parse URL jdbc:postgresql://alice:s3cret@db/app`, because `maskSensitiveValues` returns a URL without `?` unchanged. `BaseDataSource.setUrl` throws `URL invalid jdbc:postgresql://alice:s3cret@db/app` after the same warning.
With an explicit port, `jdbc:postgresql://alice:s3cret@db:5432/app` parses, `setURL` accepts it, and the host becomes `alice:s3cret@db`. The password then reaches the `FINE` records `Connecting with URL: jdbc:postgresql://alice:s3cret@db:5432/app` and `Trying to establish a protocol version 3 connection to alice:s3cret@db:5432`, and the cause of the `PSQLException` the caller gets is `java.net.UnknownHostException: alice:s3cret@db`.
Please refuse an `@` in the host part in `parseURL`, with a message that says user info is not supported and names neither the user nor the password, and mask the user-info part (everything before the last `@` in the authority) in `maskSensitiveValues` for the `Unable to parse URL` and `URL invalid` messages. The port warnings can then keep the raw value, which is what makes a typo such as `54x2` easy to find. Tests with `jdbc:postgresql://alice:s3cret@db/app` and `jdbc:postgresql://alice:s3cret@db:5432/app` would cover both forms.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGPropertyTest.java)
**minor**: the tests pass when the URL is absent from the message, and two paths have no test
`setUrlMasksCredentialsInItsError`, `malformedUrlWarningsMaskCredentials`, `connectingWithUrlMasksCredentials`, and `getConnectionMasksCredentialsInItsLog` check only that the secret is missing and that some record contains a fixed phrase. A message of `URL invalid` with no URL, or a record that drops the query string, passes all of them. Please assert the whole expected text, as `unableToParseUrlMasksCredentials` already does, for example `assertEquals("URL invalid jdbc:postgresql://localhost/a/b?password=***&sslpassword=***", e.getMessage())`.
The phrase checks can also be met by another test. `SslTest` is `@Execution(ExecutionMode.CONCURRENT)`, so it can run while this class holds the `org.postgresql.Driver` logger at `FINE`, and its connections log `Connecting with URL` too. Comparing with the URL that carries this test's closed port makes the check specific. `@Isolated`, as `BatchDeadlockTest` uses for the same reason, also stops these tests from silencing the other tests' records through `setUseParentHandlers(false)`.
Untested paths:
- the success record `Created a {0} for {1} at {2}` in `BaseDataSource.getConnection`: no test opens a connection with `sslpassword` set at `FINE`, so it can log the unmasked URL and every test still passes. It needs a server, so it belongs with the server-backed data-source tests.
- the `jdbc:postgresql:<dbname>` form (no `//`) with a database name that fails to decode, such as `jdbc:postgresql:db%zz`: the PR rewrites that `catch`, and no test parses it and expects `null`.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGPropertyTest.java)
**minor**: `malformedCredentialValueIsNotLogged` copies `recordFineMessages`
The test repeats the helper line by line, comment included; please call `recordFineMessages(Driver.class, ...)`.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 12:10 "vlsi (@vlsi)" <noreply+vlsi@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: vlsi (@vlsi) @ 2026-11-05 12:10 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/PGProperty.java)
**nit**: the sensitive set is declared 500 lines away from the properties
`SENSITIVE_PROPERTIES` sits far from `PASSWORD(` and `SSL_PASSWORD(`, and nothing reminds the author of a new property to classify it; #4251 already has to add `OAUTH_TOKEN` and `OAUTH_CLIENT_SECRET` here. A constructor flag next to `required` would put the decision where the property is declared.
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:46 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:46 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/Driver.java)
Done
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:47 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:47 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/util/PGPropertyUtil.java)
Done
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:49 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:49 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/util/PGPropertyUtil.java)
Fixed the way it's done in libpq
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:50 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:50 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/PGProperty.java:1036)
fixed
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:50 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:50 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGPropertyTest.java)
Done
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:51 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:51 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on CHANGELOG.md)
Done
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:52 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:52 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/main/java/org/postgresql/PGProperty.java)
Added constructor argument
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:53 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:53 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGPropertyTest.java)
Done
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:54 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:54 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/test/java/org/postgresql/util/PGPropertyUtilTest.java)
Done
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:55 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:55 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PGPropertyTest.java)
Done
^ permalink raw [nested|flat] 25+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs
@ 2026-11-05 16:56 "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
23 siblings, 0 replies; 25+ messages in thread
From: artemgavrilov (@artemgavrilov) @ 2026-11-05 16:56 UTC (permalink / raw)
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
@artemgavrilov requested a review.
^ permalink raw [nested|flat] 25+ messages in thread
end of thread, other threads:[~2026-11-05 16:56 UTC | newest]
Thread overview: 25+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-10-29 16:02 [pgjdbc/pgjdbc] PR #4512: fix: mask credentials in the JDBC URLs the driver logs "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-10-29 16:03 ` "gitguardian[bot] (bot) (@gitguardian[bot])" <noreply+gitguardian[bot]@github.com>
2026-10-29 17:04 ` "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` Re: [pgjdbc/pgjdbc] PR #4512 (changes requested): fix: mask credentials in the JDBC URLs the driver logs "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 12:10 ` "vlsi (@vlsi)" <noreply+vlsi@github.com>
2026-11-05 16:46 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:47 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:49 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:50 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:50 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:51 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:52 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:53 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:54 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:55 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
2026-11-05 16:56 ` "artemgavrilov (@artemgavrilov)" <noreply+artemgavrilov@github.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox