pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jchampion@timescale.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Tobias Bussmann <t.bussmann@gmx.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Mark Guertin <markguertin@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date: Thu, 06 Jul 2023 19:05:20 -0400
Message-ID: <1264127.1688684720@sss.pgh.pa.us> (raw)
In-Reply-To: <CAAWbhmi08E2okkCHjvhXtAdzqdFH+WPCbZzgRthDqVzL-HhiQw@mail.gmail.com>
References: <D816AB75-034A-4FF8-AF14-7AEAE61176C4@yesql.se>
	<ZEG9pTrrb5fdqRpS@paquier.xyz>
	<20230421.120220.1132981318960692233.horikyota.ntt@gmail.com>
	<7B26A7F6-375B-451A-8B6B-FD1CCA23FFEE@yesql.se>
	<ZEtahOGT60kql/rS@paquier.xyz>
	<D2C15F6D-D133-43D4-BC46-40120E605611@yesql.se>
	<ZEu21Ud7FitLiu7F@paquier.xyz>
	<1315ED16-F6C6-4346-9758-B048EDC9C1D1@yesql.se>
	<ZExZ510ZcfpZ5VdE@paquier.xyz>
	<121E6517-1644-4E6F-98CA-98EDC65202CC@yesql.se>
	<ZE9NXovq7cNLfPnM@paquier.xyz>
	<817432D1-864B-449F-B895-3A829ADE2A98@gmx.net>
	<0F3A9C7C-CEDA-45CC-9A75-9E2A17269324@yesql.se>
	<CAAWbhmi08E2okkCHjvhXtAdzqdFH+WPCbZzgRthDqVzL-HhiQw@mail.gmail.com>

Jacob Champion <jchampion@timescale.com> writes:
> My two cents: backpatching an exception for .DS_Store seems good, but
> creating an exclusion for all hidden files feels like a surprising
> change for stable branches.

On the whole, I think I'd vote for blocking .DS_Store only, even
in HEAD.  (IIRC, I thought differently to start with, but today
I'm feeling conservative about it.)  If there are other special
file names on other platforms, we could add some more targeted
exceptions; but dropping all hidden files seems more likely to
break things than be helpful.

			regards, tom lane





view thread (34+ messages)  latest in thread

Message-ID: <1264127.1688684720@sss.pgh.pa.us>
Permalink:  ../1264127.1688684720@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1264127.1688684720@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jchampion@timescale.com, daniel@yesql.se, t.bussmann@gmx.net, michael@paquier.xyz, horikyota.ntt@gmail.com, markguertin@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
  In-Reply-To: <1264127.1688684720@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox