From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tobias Bussmann <t.bussmann@gmx.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Mark Guertin <markguertin@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date: Fri, 21 Apr 2023 07:33:09 +0900
Message-ID: <ZEG9pTrrb5fdqRpS@paquier.xyz> (raw)
In-Reply-To: <D816AB75-034A-4FF8-AF14-7AEAE61176C4@yesql.se>
References: <E258CE50-AB0E-455D-8AAD-BB4FE8F882FB@gmail.com>
<794684A8-D3FF-4109-815F-C9EB66AF65EA@gmx.net>
<3000521.1681928151@sss.pgh.pa.us>
<ZECELdGIt2xGSWte@paquier.xyz>
<5781DAEE-66E2-41F5-BE03-E82C729F1340@yesql.se>
<CDA8E1B5-C146-4954-867A-AF5A4B9E9C43@gmx.net>
<D816AB75-034A-4FF8-AF14-7AEAE61176C4@yesql.se>
On Thu, Apr 20, 2023 at 01:15:40PM +0200, Daniel Gustafsson wrote:
> Maybe. I'm a bit hesitant to add too many smarts to pg_rewind. It's a tool
> for when something has gone wrong with a cluster (albeit probably not at the
> filesystem level), and at that point I feel it's better to put the user fully
> in charge. Perhaps I'm overly cautious, curious to hear from others.
Hmm. pg_rewind is mostly a differential block-level backup tool, so
applying the same rules everywhere across the board would be sensible
here. See that exclude_list_item is able to handle prefixes, and we
may want to extend the same logic for the directory list, as well..
By the way, the patch ought to add some tests? For pg_basebackup,
this would be around "These files should not be copied" in
010_pg_basebackup.pl. pg_checksums has also its own checks in
002_actions.pl.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../ZEG9pTrrb5fdqRpS@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, daniel@yesql.se, t.bussmann@gmx.net, tgl@sss.pgh.pa.us, markguertin@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
In-Reply-To: <ZEG9pTrrb5fdqRpS@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox