public inbox for [email protected]  

help / color / mirror / Atom feed
From: Vishal Prasanna <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: "'Álvaro Herrera'" <[email protected]>
Cc: pgsql-bugs <[email protected]>
Subject: RE: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change
Date: Mon, 09 Mar 2026 15:09:51 +0530
Message-ID: <[email protected]> (raw)
In-Reply-To: <OS9PR01MB1214923A50CA2640D572FEBE1F579A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
References: <[email protected]>
	<[email protected]>
	<OS9PR01MB12149FD6C66A344831EBD836EF572A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
	<[email protected]>
	<OS9PR01MB1214961799DAE95F5CB32EC75F57FA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
	<[email protected]>
	<OS9PR01MB1214923A50CA2640D572FEBE1F579A@OS9PR01MB12149.jpnprd01.prod.outlook.com>

Hi Hayato,

 > ``` 
 > @@ -2663,6 +2655,13 @@ ReorderBufferProcessTXN(ReorderBuffer *rb, ReorderBufferTXN *txn, 
 >          if (using_subtxn) 
 >              RollbackAndReleaseCurrentSubTransaction(); 
 >  
 > +        /* Free the specinsert change before freeing the ReorderBufferTXN */ 
 > +        if (specinsert != NULL) 
 > +        { 
 > +            ReorderBufferReturnChange(rb, specinsert, true); 
 > +            specinsert = NULL; 
 > +        } 
 > ``` 
 >  
 > In PG17-, we seem to use the term "return" to deallocate the change. Should we follow that? 
 > I have no strong opinion for it. 

Internally, `ReorderBufferReturnChange()` frees the change, which is why comment uses "Free".
Either term is fine for me.


Thanks for the review and for registering the patch.

Regards,
Vishal Prasanna
Zoho Corporation







reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: RE: [BUG] Assert failure in ReorderBufferReturnTXN during logical decoding due to leaked specinsert change
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox