pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Hugh Ranalli <hugh@whtc.ca>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: thomas.munro@enterprisedb.com, Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: Mon, 28 Jan 2019 15:45:45 +0900
Message-ID: <20190128064545.GD15401@paquier.xyz> (raw)
In-Reply-To: <20190110060945.GL2157@paquier.xyz>
References: <201901031819.hi4hjki2pzr5@alvherre.pgsql>
	<23619.1546539744@sss.pgh.pa.us>
	<CAAhbUMMrNL9uXXpwS+BPTGjKQv5Sxvr+OY2C73Ag7oFyjSOiEQ@mail.gmail.com>
	<20190104130048.GD2067@paquier.xyz>
	<CAAhbUMOj8r4=V0nQpa21SBh7tHTZ37QxXKx5JSpYqdsA-V6mSA@mail.gmail.com>
	<20190109035253.GF21835@paquier.xyz>
	<CAAhbUMNZ0ooK6SzLNdkxzdBsQHOJf_rg_EjwoNL8QHTwQuriRw@mail.gmail.com>
	<20190110060945.GL2157@paquier.xyz>

Thomas,

On Thu, Jan 10, 2019 at 03:09:45PM +0900, Michael Paquier wrote:
> OK, committed then. I have yet to study yet the other part of the
> proposal regarding diatritical characters.  Patch 3 has a conflict for
> the regression tests, so a rebase would be needed.  That's not a big
> deal though to resolve the conflict.  I am also a bit confused by the
> newly-generated unaccent.rules.  Why nothing shows up for the second
> column (around line 414 for example)?  Shouldn't we have mapping
> characters?

You are registered as a reviewer and committer of the last patch of
this thread:
https://commitfest.postgresql.org/21/1924/

Are you planning to look at it or should I jump in?  I have not looked
at the patch status in depth yet.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190128064545.GD15401@paquier.xyz/2-signature.asc)
  download

view thread (59+ messages)  latest in thread

Message-ID: <20190128064545.GD15401@paquier.xyz>
Permalink:  ../20190128064545.GD15401@paquier.xyz/
Also on:    postgresql.org/message-id/20190128064545.GD15401@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, hugh@whtc.ca, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, daniel@manitou-mail.org, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
  In-Reply-To: <20190128064545.GD15401@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox