From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
Date: Sat, 18 May 2019 18:35:22 +0900
Message-ID: <20190518093522.GA19212@paquier.xyz> (raw)
In-Reply-To: <20190517202443.gw4zdfkpwgsjdel6@alap3.anarazel.de>
References: <4643.1557931189@sss.pgh.pa.us>
<20190516013808.GA1415@paquier.xyz>
<20190516021903.GB1415@paquier.xyz>
<28927.1557977558@sss.pgh.pa.us>
<20190516035617.GC1415@paquier.xyz>
<20190516043618.GD1415@paquier.xyz>
<31437.1557982294@sss.pgh.pa.us>
<20190516060628.GE1415@paquier.xyz>
<20190517042536.GM20887@paquier.xyz>
<20190517202443.gw4zdfkpwgsjdel6@alap3.anarazel.de>
On Fri, May 17, 2019 at 01:24:43PM -0700, Andres Freund wrote:
> I don't think a windows-only patch is the same thing as a feature, one
> that makes debugging easier to boot, that's applicable to all
> platforms.
We are discussing here a set of problems which breaks the logging
collector to work on Windows, requiring mostly a Windows patch. And I
am not much willing to mess up with the area of shared memory handling
on Windows a couple of days before a beta.
>> diff --git a/src/tools/msvc/config_default.pl b/src/tools/msvc/config_default.pl
>> @@ -17,7 +17,7 @@ our $config = {
>> gss => undef, # --with-gssapi=<path>
>> icu => undef, # --with-icu=<path>
>> nls => undef, # --enable-nls=<path>
>> - tap_tests => undef, # --enable-tap-tests
>> + tap_tests => 1, # --enable-tap-tests
>> tcl => undef, # --with-tcl=<path>
>> perl => undef, # --with-perl
>> python => undef, # --with-python=<path>
>
> Hm? Is this to coerce cfbot?
This is part of the patch only because it has proved to be useful for
testing with MSVC on my VMs. I am not suggesting to add that in this
patch if this gets merged into HEAD. It is actually a good idea to
enforce that sometimes for the cfbot.. I'll remember your suggestion
for future patches.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190518093522.GA19212@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, yuli.khodorkovskiy@crunchydata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
In-Reply-To: <20190518093522.GA19212@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox