From: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: buschmann@nidsa.net
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade test for binary compatibility of core data types
Date: Wed, 16 Dec 2020 11:22:23 -0600
Message-ID: <20201216172222.GS30237@telsasoft.com> (raw)
In-Reply-To: <20201206180248.GI24052@telsasoft.com>
References: <20191010204022.6hiiubm2cueu3ghk@development>
<20191013001032.lqrn4kqaovhrf77l@development>
<17717.1570991208@sss.pgh.pa.us>
<20191013203848.2eksimmpux3546wr@development>
<27596.1571062600@sss.pgh.pa.us>
<20191014163538.cqn6j4cl7s2mk2yz@development>
<20191015001817.zei45apgpu5dzngr@development>
<20191015044118.GO3599@telsasoft.com>
<20191015070725.csmdmdvrlb6klwkg@development>
<20201206180248.GI24052@telsasoft.com>
On Sun, Dec 06, 2020 at 12:02:48PM -0600, Justin Pryzby wrote:
> I meant to notice if the binary format is accidentally changed again, which was
> what happened here:
> 7c15cef86 Base information_schema.sql_identifier domain on name, not varchar.
>
> I added a table to the regression tests so it's processed by pg_upgrade tests,
> run like:
>
> | time make -C src/bin/pg_upgrade check oldsrc=`pwd`/11 oldbindir=`pwd`/11/tmp_install/usr/local/pgsql/bin
Per cfbot, this avoids testing ::xml (support for which may not be enabled)
And also now tests oid types.
I think the per-version hacks should be grouped by logical change, rather than
by version. Which I've started doing here.
--
Justin
Attachments:
[text/x-diff] v2-0001-WIP-pg_upgrade-test.sh-changes-needed-to-allow-te.patch (0B, ../20201216172222.GS30237@telsasoft.com/2-v2-0001-WIP-pg_upgrade-test.sh-changes-needed-to-allow-te.patch)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: pryzby@telsasoft.com, tomas.vondra@2ndquadrant.com, tgl@sss.pgh.pa.us, andres@anarazel.de, buschmann@nidsa.net, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade test for binary compatibility of core data types
In-Reply-To: <20201216172222.GS30237@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox