From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
Date: Sat, 18 May 2019 12:18:28 -0400
Message-ID: <28565.1558196308@sss.pgh.pa.us> (raw)
In-Reply-To: <20190518093522.GA19212@paquier.xyz>
References: <4643.1557931189@sss.pgh.pa.us>
<20190516013808.GA1415@paquier.xyz>
<20190516021903.GB1415@paquier.xyz>
<28927.1557977558@sss.pgh.pa.us>
<20190516035617.GC1415@paquier.xyz>
<20190516043618.GD1415@paquier.xyz>
<31437.1557982294@sss.pgh.pa.us>
<20190516060628.GE1415@paquier.xyz>
<20190517042536.GM20887@paquier.xyz>
<20190517202443.gw4zdfkpwgsjdel6@alap3.anarazel.de>
<20190518093522.GA19212@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Fri, May 17, 2019 at 01:24:43PM -0700, Andres Freund wrote:
>> I don't think a windows-only patch is the same thing as a feature, one
>> that makes debugging easier to boot, that's applicable to all
>> platforms.
> We are discussing here a set of problems which breaks the logging
> collector to work on Windows, requiring mostly a Windows patch. And I
> am not much willing to mess up with the area of shared memory handling
> on Windows a couple of days before a beta.
Yeah. I started digging around this finally, and I agree that the
Windows side of it is a mess --- in particular, on Windows
internal_forkexec() calls pgwin32_ReserveSharedMemoryRegion, which
means we have a hard-wired assumption there that no postmaster child
process is launched till after shared memory exists. EXEC_BACKEND
on Unix will not reproduce that.
At this point I agree with Michael that reverting 57431a911 is the most
prudent thing to do for beta1. While it's probably not *that* hard to
fix, it will require Windows-specific testing. Moreover, the fact that
there are race conditions involved means that one person's testing might
not catch everything. So I do not think we have enough time to get a
trustworthy fix in place by Monday. And we do have other things to
worry about.
(I'm also getting annoyed that Peter, as the original author of this
commit, isn't doing anything about the issue.)
I wouldn't be totally opposed to un-reverting after beta1, if a
better-tested patch emerges. But we don't have such a patch today
and I don't see how we'll get there this weekend.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, andres@anarazel.de, peter.eisentraut@2ndquadrant.com, yuli.khodorkovskiy@crunchydata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
In-Reply-To: <28565.1558196308@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox