pg.ddx.io pgsql-bugs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
BUG #15252: "do not dump comments" in pg_restore help 3+ messages / 3 participants [nested] [flat]
Commits from this thread: 2018-06-26 c672d709b0 Fix description and documentation related to pg_restore --no-comments
* BUG #15252: "do not dump comments" in pg_restore help @ 2018-06-25 09:50 PG Bug reporting form <noreply@postgresql.org> 2018-06-25 10:26 ` Re: BUG #15252: "do not dump comments" in pg_restore help Sergei Kornilov <sk@zsrv.org> 0 siblings, 1 reply; 3+ messages in thread From: PG Bug reporting form @ 2018-06-25 09:50 UTC (permalink / raw) To: pgsql-bugs@lists.postgresql.org; +Cc: lizenko79@gmail.com The following bug has been logged on the website: Bug reference: 15252 Logged by: Andrey Lizenko Email address: lizenko79@gmail.com PostgreSQL version: 11beta1 Operating system: Ubuntu 16.04 LTS Description: pg_restore --help reports "do not dump comments" instead of "do not restore comments": postgres@db1:~$ pg_restore --help | grep comment --no-comments do not dump comments The same issue in PostgreSQL devel documentation. pg_restore tool by itself works as expected ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: BUG #15252: "do not dump comments" in pg_restore help 2018-06-25 09:50 BUG #15252: "do not dump comments" in pg_restore help PG Bug reporting form <noreply@postgresql.org> @ 2018-06-25 10:26 ` Sergei Kornilov <sk@zsrv.org> 2018-06-26 06:02 ` Re: BUG #15252: "do not dump comments" in pg_restore help Michael Paquier <michael@paquier.xyz> 0 siblings, 1 reply; 3+ messages in thread From: Sergei Kornilov @ 2018-06-25 10:26 UTC (permalink / raw) To: lizenko79@gmail.com <lizenko79@gmail.com>; pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org> Hello Thank you! I recheck behavior too, option works correct and has only wrong description. Simple patch attached. regards, Sergei Attachments:^ permalink raw reply [nested|flat] 3+ messages in threadbug15252_pg_restore_no_comments_description.patch (text/x-diff, 1.2K) download
diff --git a/doc/src/sgml/ref/pg_restore.sgml b/doc/src/sgml/ref/pg_restore.sgml index 345324b..14ac22b 100644 --- a/doc/src/sgml/ref/pg_restore.sgml +++ b/doc/src/sgml/ref/pg_restore.sgml @@ -579,7 +579,7 @@ <term><option>--no-comments</option></term> <listitem> <para> - Do not dump comments. + Do not restore comments. </para> </listitem> </varlistentry> diff --git a/src/bin/pg_dump/pg_restore.c b/src/bin/pg_dump/pg_restore.c index 2342a63..501d7ce 100644 --- a/src/bin/pg_dump/pg_restore.c +++ b/src/bin/pg_dump/pg_restore.c @@ -483,7 +483,7 @@ usage(const char *progname) printf(_(" --disable-triggers disable triggers during data-only restore\n")); printf(_(" --enable-row-security enable row security\n")); printf(_(" --if-exists use IF EXISTS when dropping objects\n")); - printf(_(" --no-comments do not dump comments\n")); + printf(_(" --no-comments do not restore comments\n")); printf(_(" --no-data-for-failed-tables do not restore data of tables that could not be\n" " created\n")); printf(_(" --no-publications do not restore publications\n"));
* Re: BUG #15252: "do not dump comments" in pg_restore help 2018-06-25 09:50 BUG #15252: "do not dump comments" in pg_restore help PG Bug reporting form <noreply@postgresql.org> 2018-06-25 10:26 ` Re: BUG #15252: "do not dump comments" in pg_restore help Sergei Kornilov <sk@zsrv.org> @ 2018-06-26 06:02 ` Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2018-06-26 06:02 UTC (permalink / raw) To: Sergei Kornilov <sk@zsrv.org>; +Cc: lizenko79@gmail.com <lizenko79@gmail.com>; pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org> On Mon, Jun 25, 2018 at 01:26:38PM +0300, Sergei Kornilov wrote: > Thank you! I recheck behavior too, option works correct and has only > wrong description. Simple patch attached. This is clearly a copy-pasto from recent commit 1368e92, nice catch. > <listitem> > <para> > - Do not dump comments. > + Do not restore comments. > </para> > </listitem> > </varlistentry> This is not consistent with the other --no-XXX switches, so I have reworded the documentation fix to be more consistent with the rest and pushed the patch. I can confirm as well after some manual testing that the feature behaves as documented. Thanks for the report and the patch! -- Michael Attachments: signature.asc (application/pgp-signature, 832B) download ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2018-06-26 06:02 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2018-06-25 09:50 BUG #15252: "do not dump comments" in pg_restore help PG Bug reporting form <noreply@postgresql.org> 2018-06-25 10:26 ` Sergei Kornilov <sk@zsrv.org> 2018-06-26 06:02 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox