pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: Christophe Pettus <xof@thebuild.com>
To: Wolfgang Walther <walther@technowledgy.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
Date: Wed, 20 Mar 2024 07:02:48 +0100
Message-ID: <ac80cff7-cc8f-4eee-ba4f-12d0fc902e0c@eisentraut.org> (raw)
In-Reply-To: <68C88EE3-CDCB-4993-9173-3A773F491F3A@thebuild.com>
References: <fddd1cd6-dc16-40a2-9eb5-d7fef2101488@technowledgy.de>
	<2852940.1710599083@sss.pgh.pa.us>
	<443da167-ee01-47d2-9c83-105694b4cbd5@technowledgy.de>
	<CA+hUKGJhp0opkCybdOrbQSMyHX8cRuLh2ygkqtivizCqK6kfOA@mail.gmail.com>
	<CA+hUKGL=CE7Gg5p7ijbtEWhnPR-Ua4gemhuz-kQpSy3dD1+SYQ@mail.gmail.com>
	<ef1b47df-0808-4bd7-b08c-5153d5d75f4c@technowledgy.de>
	<68C88EE3-CDCB-4993-9173-3A773F491F3A@thebuild.com>

On 17.03.24 11:33, Christophe Pettus wrote:
>> On Mar 17, 2024, at 02:44, Wolfgang Walther <walther@technowledgy.de> wrote:
>>
>> Nailed it. PS_USE_NONE fixes it.
> 
> Given the musl (still?) does not define a preprocessor macro specific to it, is there a way of improving the test in pg_status.c to catch this case?  It seems wrong that the current test passes a case that doesn't actually work.
> 

We could turn it around and do

#if defined(__linux__)
#if defined(__GLIBC__) || defined(__UCLIBC__ )
#define PS_USE_CLOBBER_ARGV
#else
#define PS_USE_NONE
#endif
#endif






view thread (86+ messages)  latest in thread

Message-ID: <ac80cff7-cc8f-4eee-ba4f-12d0fc902e0c@eisentraut.org>
Permalink:  ../ac80cff7-cc8f-4eee-ba4f-12d0fc902e0c@eisentraut.org/
Also on:    postgresql.org/message-id/ac80cff7-cc8f-4eee-ba4f-12d0fc902e0c@eisentraut.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: peter@eisentraut.org, xof@thebuild.com, walther@technowledgy.de, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org
  Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
  In-Reply-To: <ac80cff7-cc8f-4eee-ba4f-12d0fc902e0c@eisentraut.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox