From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Damir Belyalov <dam.bel07@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor background psql TAP functions
Date: Wed, 17 May 2023 14:38:15 +0200
Message-ID: <0AFDFD10-178D-44FA-86A7-0909227119D5@postgresql.org> (raw)
In-Reply-To: <27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org>
References: <E1pksad-001uk0-CL@gemulon.postgresql.org>
<c0ba3008-dbc8-e53f-29f2-2e9abe72b2a2@enterprisedb.com>
<34800305-E1E6-4194-8738-9977946DB12A@postgresql.org>
<CALH1Lgui397s_4AXWm1ZO_uCLOUVL1HAa0TO9CbdMy1kvokkzA@mail.gmail.com>
<27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org>
> On 16 May 2023, at 21:43, Daniel Gustafsson <dgustafsson@postgresql.org> wrote:
>
>> On 16 May 2023, at 21:04, Damir Belyalov <dam.bel07@gmail.com> wrote:
>
>> There is another perl module: AdjustUpgrade.pm that is not in Makefile. Do we need it?
>
> Yes, I think it should be installed too and skimming the linked thread I see no
> mention of the omission being deliberate. I will take care of it.
The attached is the proposed fix, which will have to be backpatched to v11 to
match the original commit. Unless there are reasons to treat this module
differently from the others wrt installation I'll go ahead and fix it in time
for beta1.
--
Daniel Gustafsson
Attachments:v1-0001-Add-installation-rules-for-AdjustUpgrade-test-mod.patch (application/octet-stream, 2.3K) download
From 118aa36deefbac4cf54871fa9be0f2e54f67e74f Mon Sep 17 00:00:00 2001
From: Daniel Gustafsson <dgustafsson@postgresql.org>
Date: Wed, 17 May 2023 14:29:49 +0200
Subject: [PATCH v1] Add installation rules for AdjustUpgrade test module
Commit 52585f8f07 introduced a new Perl test module but didn't add
it as an installation target like the other modules are.
Backpatch into all supported versions.
Reported-by: Damir Belyalov <dam.bel07@gmail.com>
Discussion: https://postgr.es/m/CALH1Lgui397s_4AXWm1ZO_uCLOUVL1HAa0TO9CbdMy1kvokkzA@mail.gmail.com
Backpatch-through: v11
---
src/test/perl/Makefile | 2 ++
src/test/perl/meson.build | 1 +
2 files changed, 3 insertions(+)
diff --git a/src/test/perl/Makefile b/src/test/perl/Makefileindex 435b45a6cc..716bec76be 100644--- a/src/test/perl/Makefile+++ b/src/test/perl/Makefile@@ -24,6 +24,7 @@ install: all installdirs
$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/RecursiveCopy.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/RecursiveCopy.pm'
$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Cluster.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm'
$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/BackgroundPsql.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/BackgroundPsql.pm'
+ $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/AdjustUpgrade.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm'
$(INSTALL_DATA) $(srcdir)/PostgreSQL/Version.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Version.pm'
uninstall:
@@ -32,6 +33,7 @@ uninstall:
rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/RecursiveCopy.pm'
rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm'
rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/BackgroundPsql.pm'
+ rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm'
rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Version.pm'
endif
diff --git a/src/test/perl/meson.build b/src/test/perl/meson.buildindex 101e8a2b8f..041e892029 100644--- a/src/test/perl/meson.build+++ b/src/test/perl/meson.build@@ -12,4 +12,5 @@ install_data(
'PostgreSQL/Test/RecursiveCopy.pm',
'PostgreSQL/Test/Cluster.pm',
'PostgreSQL/Test/BackgroundPsql.pm',
+ 'PostgreSQL/Test/AdjustUpgrade.pm',
install_dir: dir_pgxs / 'src/test/perl/PostgreSQL/Test')
--
2.32.1 (Apple Git-133)
=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, tgl@sss.pgh.pa.us, dam.bel07@gmail.com, peter.eisentraut@enterprisedb.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor background psql TAP functions
In-Reply-To: <0AFDFD10-178D-44FA-86A7-0909227119D5@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox