pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Lætitia Avrot <laetitia.avrot@gmail.com>
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
Date: Wed, 13 Mar 2019 22:44:30 -0400
Message-ID: <1225.1552531470@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoaL2K-FXYuANu+uXQEFo4qcSG+qqtqb54pnWM1g99RUrw@mail.gmail.com>
References: <E1h3nUY-0000sM-Vf@gemulon.postgresql.org>
	<20190313022159.GR13812@paquier.xyz>
	<24813.1552447002@sss.pgh.pa.us>
	<20190313050331.GT13812@paquier.xyz>
	<17820.1552514192@sss.pgh.pa.us>
	<CAEZATCX-mFwmx0NKbGsYJ6RAo8Hb=c+_CeNNXWQ7-BmK2_XVWw@mail.gmail.com>
	<27340.1552524529@sss.pgh.pa.us>
	<CA+Tgmoa6Q1MGOnDuFjoJ7mBsatndxnhUNkk8Jv0n6cZS83efcg@mail.gmail.com>
	<1015.1552531143@sss.pgh.pa.us>
	<CA+TgmoaL2K-FXYuANu+uXQEFo4qcSG+qqtqb54pnWM1g99RUrw@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Mar 13, 2019 at 10:39 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> No, but that's not the hazard.  I have a very fresh-in-mind example:
>> at one point while tweaking Laetitia's patch, I'd accidentally changed
>> datanh so that it called tanh not atanh.  The previous set of tests did
>> not reveal that :-(

> Well, that was a goof, but it's not likely that such a regression will
> ever be reintroduced.

Sure, but how about this for another example: maybe a given platform
hasn't got these functions (or they're in a different library we
didn't pull in), but you don't see a failure until you actually
call them.  We try to set up our link options so that that sort
of failure is reported at build time, but I wouldn't care to bet
that we've succeeded at that everywhere.

			regards, tom lane




view thread (20+ messages)  latest in thread

Message-ID: <1225.1552531470@sss.pgh.pa.us>
Permalink:  ../1225.1552531470@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1225.1552531470@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, dean.a.rasheed@gmail.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, laetitia.avrot@gmail.com
  Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
  In-Reply-To: <1225.1552531470@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox